Repository navigation
feat: SQL query filter follow-ups: table autocomplete, type rename, type-switch fix, E2E tests - #3719
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 04ac458 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
038f28f to
faebc7c
Compare
d6d0be2 to
20d5442
Compare
faebc7c to
08849ac
Compare
🔵 Tier 2 — Low RiskSmall, isolated change with no API route or data model modifications. Why this tier:
Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns. Stats
|
Duplicate code analysisNo new duplicate code introduced by this PR. jscpd compared this branch against |
PR Review
3 finding(s): 🔴 0 P0/P1 · 🟡 0 P2 · 🔵 3 P3 No inline comments. 3 P3 folded at the bottom. 🔵 3 P3 — no action needed before merge
Priority comes from a separate grading pass over the finished review. P3 is folded here instead of posted inline. No finding blocks merge automatically; a maintainer decides. |
E2E Test Results✅ All tests passed • 479 passed • 1 skipped • 1063s
Tests ran across 4 shards in parallel. |
Deep Review✅ No critical issues found. The three substantive changes are sound. The 🟡 P2 -- recommended
🔵 P3 nitpicks (2)
Reviewers (7): correctness, testing, maintainability, project-standards, kieran-typescript, julik-frontend-races, adversarial. Testing gaps:
No finding blocks merge automatically. A maintainer will expect P0/P1 findings in code this PR changes to be fixed; P2/P3 are your call -- fix or reply. Never fix findings about surrounding code here; reply instead. Do not widen the PR. How to respond |
Summary
Follow-ups from review on #3678: autocomplete table and column names in the SQL query filter editor, rename "Queried values", fix a validation bug when switching filter types, and add E2E coverage for SQL query filters. One commit per change:
getTableConnectionsForConnection()inutils.ts, which both editors use.$__sourceTableand$__filter, a connection variable, a data source variable, and a query error shown in the preview and on the dropdown.Screenshots or video
Not captured. The visible changes are autocomplete suggestions in the SQL query filter editor and the renamed, reordered type dropdown.
How to reproduce
Starting point:
yarn dev, any dashboard, with a Logs source on the local connection.On
main:On this branch:
otel. The tables of the connection's sources are suggested, and afterFROM, their columns.How to test on Vercel preview
Preview routes: /dashboards
Steps:
SELECT * FROM otelin the SQL editor. Verify table names appear in the suggestions.References