Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changeset/theme-field-background-tokens.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
'@hyperdx/app': patch
---

In dark mode, the field background now has opacity so it works on different
backgrounds, such as popovers. It is set directly in the theme tokens instead of
through a Click UI token that resolved to a solid color.
6 changes: 2 additions & 4 deletions packages/app/src/theme/_tokens.scss
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@
--click-global-color-title-default: rgb(97.5% 97.5% 97.5%);
--click-global-color-title-muted: #b3b6bd;
--click-global-color-outline-default: #faff69;
--click-field-color-background-default: #2d2d2d;

/* Backgrounds - Using Click UI tokens */
--color-bg-body: var(--click-global-color-background-default);
Expand Down Expand Up @@ -132,7 +131,7 @@
(Select/Combobox options, Menu items, popover/dropdown lists) when it is
hovered or is the currently-selected entry. */
--color-bg-option-active: var(--palette-neutral-712);
--color-bg-field: var(--click-field-color-background-default);
--color-bg-field: rgb(255 255 255 / 6%);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 P2 — Translucent field token makes the floating SQL autocomplete info panel see-through in dark mode

packages/app/src/components/SQLEditor/utils.ts:175 sets .cm-completionInfo to var(--color-bg-field). CodeMirror positions that panel absolutely outside the autocomplete tooltip (left: 100% / right: 100%), so the tooltip's --color-bg-surface does not sit behind it. At 6% white, the editor text and page content under the panel now show through the help text. Give the panel an opaque surface such as var(--color-bg-surface), or keep an opaque value for floating uses of the token.

Advisory. Fix if it is a small defect in code this PR changes; otherwise reply in the thread. Do not widen the PR or touch files it did not already change. How to respond

--color-bg-field-highlighted: var(--palette-neutral-650);
--color-bg-field-addon: var(--palette-neutral-712);
--color-bg-neutral: #4d4f66;
Expand Down Expand Up @@ -328,7 +327,6 @@
--click-global-color-title-default: lch(11.126% 1.374 305.43deg);
--click-global-color-title-muted: #696e79;
--click-global-color-outline-default: #437eef;
--click-field-color-background-default: #fbfcff;

/* Backgrounds - Using Click UI tokens */
--color-bg-body: var(--click-global-color-background-default);
Expand Down Expand Up @@ -358,7 +356,7 @@
(Select/Combobox options, Menu items, popover/dropdown lists) when it is
hovered or is the currently-selected entry. */
--color-bg-option-active: var(--click-global-color-background-muted);
--color-bg-field: var(--click-field-color-background-default);
--color-bg-field: #fbfcff;
--color-bg-field-highlighted: var(--click-global-color-background-default);
--color-bg-field-addon: var(--click-global-color-background-default);
--color-bg-neutral: #adb5bd;
Expand Down
Loading