Skip to content

chore: Fix trivial lint warnings - #3754

Open
pulpdrew wants to merge 7 commits into
mainfrom
drew/fix-trivial-lints
Open

pulpdrew wants to merge 7 commits into
mainfrom
drew/fix-trivial-lints

Conversation

@pulpdrew

@pulpdrew pulpdrew commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fix trivial lint warnings in app, one per commit, reducing the warning count from 569 --> 534. Rules that have been completely resolved are now errors instead of warnings.

Rule New Warning Ceiling
jsx-key-before-spread: moved key ahead of the spread in 4 places 565
use-state: 12 setter renames and 8 lazy initializers 545
no-unnecessary-use-prefix: useSourceMappedFrame → getSourceMappedFrame, file renamed to src/sourceMappedFrame.ts 544
id-name: _id → reactId 543
no-unsafe-function-type: the nuqs createParser mock is now a generic pass-through 541
no-clone-element: render-prop TestForm in the InputControlled test; the Sparkline test mock renders the real ResponsiveContainer at a fixed size 534

Screenshots or video

No behavior changes

How to test on Vercel preview

References

  • Linear Issue:
  • Related PRs:

@pulpdrew
pulpdrew requested a review from a team as a code owner November 21, 2026 14:40
@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
hyperdx-oss Ready Ready Preview Nov 21, 2026 2:54pm UTC
hyperdx-storybook Ready Ready Preview Nov 21, 2026 2:54pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Nov 21, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: f2b9d3a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions Bot added the review/tier-2 Low risk — AI review + quick human skim label Nov 21, 2026
@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

🔵 Tier 2 — Low Risk

Small, isolated change with no API route or data model modifications.

Why this tier:

  • Standard feature/fix — introduces new logic or modifies core functionality

Review process: AI review + quick human skim (target: 5–15 min). Reviewer validates AI assessment and checks for domain-specific concerns.
SLA: Resolve within 4 business hours.

Stats
  • Production files changed: 26
  • Production lines changed: 130 (+ 93 in test files, excluded from tier calculation)
  • Branch: drew/fix-trivial-lints
  • Author: pulpdrew

To override this classification, remove the review/tier-2 label and apply a different review/tier-* label. Manual overrides are preserved on subsequent pushes.

@github-actions

Copy link
Copy Markdown
Contributor

Duplicate code analysis

No new duplicate code introduced by this PR.


jscpd compared this branch against origin/main
across app, api and common-utils. Only new clones are listed; the codebase
currently holds 108 in total (1.13%).
Run yarn dupes locally to reproduce, or yarn dupes:all for the full picture.

@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

PR Review

✅ No issues found.

@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Deep Review

✅ No critical issues found.

This is a mechanical lint-cleanup diff (setter renames, lazy useState initializers, key-before-spread reordering, a non-hook rename, and two test refactors), and verification confirms every edit is behavior-preserving. The highest-risk edits were checked directly against the full files:

  • packages/app/src/SessionSubpanel.tsx and packages/app/src/components/SearchInput/AutocompleteInput.tsx swap the names of a raw useState setter and its wrapping useCallback. Every call site was confirmed to bind to the intended target — the URL-reaction effect correctly keeps the raw setter, and all side-effecting call sites (updateFocus, updateSearchInputFocus) retain the wrapper. No call site silently lost the URL-query-state or dropdown-open side effect.
  • The @eslint-react/jsx-key-before-spread reorderings in the Kubernetes side panels and DBRowOverviewPanel are safe: the spread objects are React props / local object literals that cannot carry a key, so moving key ahead of the spread cannot change which key wins.
  • Lazy-init conversions are equivalent: getMetadata takes no arguments, so useState(getMetadata) matches the prior useState(getMetadata()), and the () => new Set() / () => ms('30s') forms preserve first-render values.
  • Removed state in KubernetesDashboardPage.tsx / ServicesDashboardPage.tsx and the useSourceMappedFrame → getSourceMappedFrame rename leave no stale references anywhere in the package.

No P2 or P3 findings survived re-grading — remaining differences are pure linter-governed style, which is out of review scope.


Reviewers (5): correctness, testing, maintainability, kieran-typescript, previous-comments (prior comments were automated bot notices only — Vercel, changeset, triage, jscpd, e2e — with no human feedback to verify).

Testing gaps: None — the InputControlled, Sparkline, and useDashboardFilters test refactors preserve their original assertions.

@github-actions

github-actions Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

E2E Test Results

✅ All tests passed • 472 passed • 1 skipped • 1089s

Status Count
✅ Passed 472
❌ Failed 0
⚠️ Flaky 12
⏭️ Skipped 1

Tests ran across 4 shards in parallel.

View full report →

This branch was successfully deployed

2 active deployments
Preview – hyperdx-storybook — f2b9d3a3 Deployed Nov 21, 2026 by vercel[bot]
Preview – hyperdx-oss — f2b9d3a3 Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review/tier-2 Low risk — AI review + quick human skim

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant