Repository navigation
Add a tests:run-core-sql label that runs the upstream SQL tests on a pull request - #1237
Open
polyglotAI-bot wants to merge 1 commit into
Open
polyglotAI-bot wants to merge 1 commit into
polyglotAI-bot wants to merge 1 commit into
Conversation
…pull request upstream-sql-tests.yml runs nightly, manually, and on pull requests that change the harness or the workflow. A pull request that changes only the client does not start it. - upstream-sql-tests-label.yml starts on a pull_request `labeled` event. When the label is tests:run-core-sql, it calls upstream-sql-tests.yml and then removes the label. A second workflow is necessary because the `paths` filter of the pull_request trigger also applies to a `labeled` event. - upstream-sql-tests.yml gets a workflow_call trigger. Nothing else changes. - The trigger is pull_request, not pull_request_target: the tests need no secrets, and the code of a fork runs with a read-only token. That token cannot remove the label, so the remove-label job skips forks. - The README (CI) documents the label. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AI review gate — auto-approval withheldThe AI review gate is green, but the approver did not approve What to do: ask someone with write access who is not the PR author to approve this pull request. History (latest 5 heads, newest first) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upstream-sql-tests.yml(the core SQL test harness, #1223) runs nightly, manually, and on pull requests that change the harness or the workflow. A pull request that changes only the client does not start it. This PR adds thetests:run-core-sqllabel, which runs the harness on any pull request. The same label exists in clickhouse-cs (ClickHouse/clickhouse-cs#749, merged).upstream-sql-tests-label.yml: on apull_requestlabeledevent with the labeltests:run-core-sql, it callsupstream-sql-tests.ymland then removes the label. To run the tests again, add the label again. A second workflow is necessary because thepathsfilter of thepull_requesttrigger also applies to alabeledevent.upstream-sql-tests.ymlgets aworkflow_call:trigger. Nothing else changes in it.pull_request, notpull_request_target: the tests need no secrets, and the code of a fork runs with a read-only token. That token cannot remove the label, soremove-labelskips forks (the README says to remove it by hand). Only the separateremove-labeljob getspull-requests: write.github.workflowis the name of the calling workflow), so a push to the same pull request does not cancel it.AGENTS.mddoes not change: a client fix for a harness finding changesallowlist.txt, so it already starts the workflow.The label exists in the repository now. No changelog entry: CI only, no change to the client.
Checklist
ubuntu-26.04, which this actionlint version does not know (it reports the same forupstream-sql-tests.ymlonmain). zizmor 1.29.0: no findings on the new file; onupstream-sql-tests.ymlthe same 5 findings as onmain.Remove the tests:run-core-sql label). The path run of the same pull request (44846270641) ran at the same time, passed, and was not cancelled.🤖 Generated with Claude Code
Note
Low Risk
CI and documentation only; no application code, secrets, or client behavior changes.
Overview
Adds a
tests:run-core-sqlPR label so maintainers can run the curated ClickHouse upstream SQL harness on pull requests that would not otherwise trigger it (for example client-only changes).A new
upstream-sql-tests-label.ymlworkflow listens forpull_requestlabeledevents, invokes the existing test workflow viaworkflow_call, and runs a follow-up job to delete the label when the run finishes (re-add the label to test a later push). Label removal is skipped for fork PRs because the read-only token cannot write; the harness README notes manual removal there. The test workflow job keepscontents: readonly;pull-requests: writeis isolated in the remove-label job.upstream-sql-tests.ymlgains aworkflow_calltrigger (plus a short comment); other triggers are unchanged. The harness README CI section documents the label workflow.Reviewed by Cursor Bugbot for commit 40d8922. Bugbot is set up for automated code reviews on this repo. Configure here.