Repository navigation
fix: correct escaped single quote parsing in Enum type strings - #1844
chaewonkong wants to merge 8 commits into
Conversation
SummaryThis PR fixes two real bugs in Should fixMissing regression test in Nits
VerdictRequest changes |
SummaryThis PR fixes two bugs in
Both fixes are correct. The adjusted-position formula ( Should fixIntegration test covers only native TCP; not HTTP or func Test1839Std(t *testing.T) {
testEnv, err := clickhouse_tests.GetTestEnvironment("issues")
require.NoError(t, err)
db, err := clickhouse_tests.TestClientWithDefaultSettingsStd(testEnv)
// ... same table + insert + query pattern
}Nits
VerdictApprove |
SummaryThis PR fixes two bugs in Should fix
Nits
VerdictApprove — the core logic fixes are correct and the unit-test coverage is solid. Addressing protocol coverage in the integration test before merge would be ideal. |
|
The CI failure in test (1.25, 25.10) seems unrelated to this PR. Test1229 is flaky and fails intermittently on main. |
1d91cf7 to
5d0ac85
Compare
🤖 Claude reviewFixes two bugs in Verified by trace:
Coverage: parser unit tests for both enum widths, plus Follow-ups (not blocking):
Blind spots: could not run the integration tests against a live server in this review; the parser behaviour was verified by hand-tracing the new unit cases. Verdict: ✅ Approve General findings
Inline comments are attached to the relevant lines. This summary updates in place on re-review. |
must108
left a comment
There was a problem hiding this comment.
Hi @chaewonkong, thanks for the contributions. Please address the nits from agent, LGTM otherwise.
|
Thanks for the work here @chaewonkong. #2120 just merged which supersedes this. I ran all the test cases you introduced here against what I just merged and they all pass. Closing. Thanks again for the work though! Appreciate the effort. |
Summary
Fix incorrect parsing of escaped single quotes in
Enum8/Enum16type strings.Two bugs existed in
extractEnumNamedValuesinlib/column/enum.go:skippedValueTokenswas never reset between values, causing escape positions from a previous enumvalue to bleed into the next one.
removals, causing off-by-one corruption.
Checklist
Delete items not relevant to your PR: