Repository navigation
ci: run the upstream SQL tests on a pull request with the tests:run-core-sql label - #628
Merged
Merged
Conversation
…ore-sql label upstream-sql-tests.yml runs nightly, by hand, and on pull requests that change the harness or the workflow. A pull request that changes only the driver does not start it. The new workflow upstream-sql-tests-label.yml starts on a pull_request `labeled` event, calls upstream-sql-tests.yml (new `workflow_call:` trigger) when the label is tests:run-core-sql, and then removes the label. A second workflow is necessary because the `paths` filter of the pull_request trigger also applies to a `labeled` event. The trigger is pull_request, not pull_request_target: the tests need no secrets, and the code of a fork runs with a read-only token. The remove-label job is a separate job with `pull-requests: write`, and it skips forks (their token cannot write). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AI review gate — auto-approval withheldThe AI review gate is green, but the approver did not approve What to do: ask someone with write access who is not the PR author to approve this pull request. History (latest 5 heads, newest first) |
This was referenced Nov 19, 2026
ccoltx
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upstream-sql-tests.yml(the core SQL test harness, #624) runs nightly, by hand, and on pull requests that change the harness or the workflow. A pull request that changes only the driver does not start it. This PR adds thetests:run-core-sqllabel, which runs the harness on any pull request.upstream-sql-tests-label.yml: it starts onpull_requestlabeled, callsupstream-sql-tests.yml(uses: ./…, the merge commit of the pull request) when the label istests:run-core-sql, and then removes the label. To run the tests again, add the label again.upstream-sql-tests.ymlgets aworkflow_call:trigger. Nothing else changes in it. A second workflow is necessary because thepathsfilter of thepull_requesttrigger also applies to alabeledevent.pull_request, notpull_request_target: the tests need no secrets, and the code of a fork runs with a read-only token. The calling job hascontents: read, as the top-levelpermissions:ofupstream-sql-tests.yml. The fork token cannot remove the label, so theremove-labeljob (the only job withpull-requests: write) skips forks; the README says to remove the label by hand there.github.workflowis the name of the calling workflow), so it does not cancel a run that a push to the same pull request started.README.md(CI) andAGENTS.md(rule 2: check a driver fix with the label) document the label.The label exists in the repository now. The same label was added to clickhouse-cs (ClickHouse/clickhouse-cs#749).
No changelog entry: CI only, no change to the driver.
Checklist
upstream-sql-tests.yml, zizmor reports onlyunpinned-usesfor the action tags that are already onmaster(the repo has no zizmor policy; this PR does not change those lines).{odbcdriver2} × 4shards, thenRemove the tests:run-core-sql label: the label is gone). The path-triggered run of the same commit ran at the same time and was not cancelled: run 44557541061, all jobs passed.Shard 1 of the label run failed on one allowlisted test,
03024_total_rows_approx_is_set_for_system_zeros_and_generate_random:SQLGetData(column 9 "c9"): ... Cannot interpret '-688190331020160616889455.0792753657544' as Decimal/Numeric: value is too big for internal representation.generateRandom()without arguments makes a random structure and random values, so the test sometimes gets a Decimal value over 2^64-1, which the known driver bug of the[numeric-64bit]group inallowlist.txtcannot read. The same shard passed in the path-triggered run of the same commit. The push run onmasteralso failed shard 1, on another allowlisted test (run 44552680110,05325_string_filters_columns_cache_guard). This PR changes no driver or harness code; the intermittent allowlist tests are a separate change.🤖 Generated with Claude Code