Refactor: libstonithd: Clean up stonith__watchdog_fencing_enabled_for_node_api() - #4155
Open
nrwahl2 wants to merge 9 commits into
Open
Refactor: libstonithd: Clean up stonith__watchdog_fencing_enabled_for_node_api()#4155nrwahl2 wants to merge 9 commits into
nrwahl2 wants to merge 9 commits into
Conversation
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
It's guaranteed to return non-NULL. Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
For readability. Also compare directly against NULL. Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
"No watchdog device" doesn't seem worthy of a notice-level log message. Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
...from stonith__watchdog_fencing_enabled_for_node_api() to stonith__watchdog_fencing_enabled_for_node(). Also, the only other caller that passes a non-NULL stonith argument guarantees that it's already connected. So move the connect() call to the wrapper too. Signed-off-by: Reid Wahl <nrwahl@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
But I don't bother changing the incredibly long function name in this PR.