Skip to content

Follow-up nits from the PR #8 review - #10

Merged
estcarisimo merged 1 commit into
mainfrom
fix/review-nits-software-ietf
Sep 29, 2026
Merged

estcarisimo merged 1 commit into
mainfrom
fix/review-nits-software-ietf

Conversation

@estcarisimo

Copy link
Copy Markdown
Collaborator

Nits deferred from the round-2 review of #8 (see its last comment):

  1. Repo cards at 320 px: they overhung the column by 16 px. The grid now uses minmax(min(20rem, 100%), 1fr), with unquote() so libsass passes min() through. Checked at 320 px: the card ends at the column edge and there is no horizontal scroll.
  2. AURA draft link: its Datatracker link redirected to the RFC 9198 page, which the RFC card already links. It now points to the draft's history.
  3. Card height: repo cards stretched to the row height, so the hover and focus box was taller than shorter cards. Fixed with align-self: start.
  4. French and English wording: the pages now name the IETF Day organizer by its official name, Grupo de Trabajo de Ingeniería de Internet / Argentina (IETF Argentina). The previous wording read like a formal IETF working group.

The build and pre-commit pass locally.

🤖 Generated with Claude Code

…story link, IETF Argentina name

- Repo cards fit a 320 px screen (minmax(min(20rem, 100%), 1fr)) and keep
  their own height, so the hover/focus box matches the card.
- The draft-ietf-ippm-route card links to its Datatracker history instead of
  redirecting to the RFC page the RFC card already links.
- EN/FR name the workshop's organizer by its official name, Grupo de Trabajo
  de Ingeniería de Internet / Argentina (IETF Argentina).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@estcarisimo

Copy link
Copy Markdown
Collaborator Author

Review round 1, fresh Sonnet reviewer following .github/REVIEW.md

VERDICT: APPROVE. Checks: build pass, CI steps pass, internal links 0 errors (3189 total), pre-commit pass including zizmor.

Verified:

  • Grid widths: at 320 px the grid is one 288 px column, with cards from 16 to 304 px and no horizontal scroll. At 375 px it is one 343 px column. At 1280 px it is two columns of about 377 px, above the 360 px natural minimum.
  • Compiled CSS: libsass emits minmax(min(20rem, 100%), 1fr) literally. .repo-card has align-self: start, so card heights now differ per row.
  • Datatracker link: the history URL returns 200 with no redirect to the RFC page.
  • Wording: the EN and FR text uses the official name Grupo de Trabajo de Ingeniería de Internet / Argentina (IETF Argentina), matching the JAIIO pages, and reads naturally.
  • Links and content: the only new external URL is the history link. There are no e-mail addresses and no cnet.fi.uba.ar links.

@estcarisimo
estcarisimo merged commit f2e9729 into main Sep 29, 2026
5 checks passed
@estcarisimo
estcarisimo deleted the fix/review-nits-software-ietf branch September 29, 2026 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant