Repository navigation
Follow-up nits from the PR #8 review - #10
Merged
Merged
Conversation
…story link, IETF Argentina name - Repo cards fit a 320 px screen (minmax(min(20rem, 100%), 1fr)) and keep their own height, so the hover/focus box matches the card. - The draft-ietf-ippm-route card links to its Datatracker history instead of redirecting to the RFC page the RFC card already links. - EN/FR name the workshop's organizer by its official name, Grupo de Trabajo de Ingeniería de Internet / Argentina (IETF Argentina). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Collaborator
Author
Review round 1, fresh Sonnet reviewer following
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nits deferred from the round-2 review of #8 (see its last comment):
minmax(min(20rem, 100%), 1fr), withunquote()so libsass passesmin()through. Checked at 320 px: the card ends at the column edge and there is no horizontal scroll.align-self: start.The build and pre-commit pass locally.
🤖 Generated with Claude Code