feat(vitest): call setup and teardown when running suite - #46
Closed
GuillaumeLagrange wants to merge 1 commit into
Closed
feat(vitest): call setup and teardown when running suite#46GuillaumeLagrange wants to merge 1 commit into
GuillaumeLagrange wants to merge 1 commit into
Conversation
GuillaumeLagrange
marked this pull request as draft
July 18, 2025 14:06
CodSpeed Performance ReportMerging #46 will not alter performanceComparing Summary
|
GuillaumeLagrange
deleted the
cod-1161-support-benchmark-hooks-in-vitest
branch
August 19, 2025 10:07
adriencaccia
added a commit
that referenced
this pull request
Sep 1, 2026
…is mode The analysis runner drives each benchmark itself instead of handing it to tinybench, and it never read the `setup` and `teardown` hooks a benchmark declares through its options, so they were silently skipped in simulation and memory modes. Walltime mode was unaffected: it delegates to Vitest's default execution, where tinybench invokes them. Build the same Bench and Task Vitest builds for a benchmark, and call the hooks around the warmup and the measured run, matching tinybench's cycle semantics and keeping them outside the instrumentation window. Supersedes #46 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.