Update PR review bot to complete on first approval while still requesting two reviewers - #337
Merged
Merged
Conversation
Co-authored-by: nourshoreibah <168875317+nourshoreibah@users.noreply.github.com>
Copilot
AI
changed the title
Update review bot to mark PR approved after one approval
Update PR review bot to complete on first approval while still requesting two reviewers
Aug 20, 2026
Copilot created this pull request from a session on behalf of
nourshoreibah
August 20, 2026 00:59
View session
nourshoreibah
marked this pull request as ready for review
August 20, 2026 01:00
nourshoreibah
approved these changes
Aug 20, 2026
nourshoreibah
approved these changes
Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
📝 Description
The review bot was still waiting on all assigned reviewers before treating a PR as approved, which conflicted with the updated 1-approval merge policy. This change aligns bot completion logic with that policy while preserving two-reviewer assignment for coverage.
Briefly list the changes made to the code:
pr-review-status.ymlapprovedand none are currentlychanges_requested.reviewedwhen threshold is met (or when all reviewers are done).pr-reviewer-remind.yml.github/AGENTS.md✔️ Verification
Provide screenshots of any new components, styling changes, or pages.
Not applicable (workflow/documentation-only change).
🏕️ (Optional) Future Work / Notes
We may want distinct Slack terminal labels for: