Skip to content

Update PR review bot to complete on first approval while still requesting two reviewers - #337

Merged
nourshoreibah merged 1 commit into
mainfrom
copilot/update-pr-review-bot-approval
Aug 20, 2026
Merged

Update PR review bot to complete on first approval while still requesting two reviewers#337
nourshoreibah merged 1 commit into
mainfrom
copilot/update-pr-review-bot-approval

Conversation

Copilot AI commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

ℹ️ Issue

📝 Description

The review bot was still waiting on all assigned reviewers before treating a PR as approved, which conflicted with the updated 1-approval merge policy. This change aligns bot completion logic with that policy while preserving two-reviewer assignment for coverage.

Briefly list the changes made to the code:

  1. pr-review-status.yml
    • Added approval-threshold logic: PR is treated as complete when any participant has approved and none are currently changes_requested.
    • Updated terminal handling to mark bot state as reviewed when threshold is met (or when all reviewers are done).
    • Updated Slack status/header wording to reflect threshold-based completion.
  2. pr-reviewer-remind.yml
    • Switched completion detection to latest per-reviewer state instead of “all assigned reviewed” only.
    • Stops reminders once approval threshold is met; continues reminders only when still pending.
  3. .github/AGENTS.md
    • Updated PR review bot workflow docs to match new approval-completion behavior.
const approvalMet = participantStatuses.includes('approved') &&
                    !participantStatuses.includes('changes_requested');

if ((approvalMet || allDone) && prData.status === 'open') {
  prData.status = 'reviewed';
}

✔️ Verification

Provide screenshots of any new components, styling changes, or pages.

Not applicable (workflow/documentation-only change).

🏕️ (Optional) Future Work / Notes

We may want distinct Slack terminal labels for:

  • “Approval requirement met” (merge policy satisfied)
  • “All requested reviewers responded” (full review coverage complete)

Co-authored-by: nourshoreibah <168875317+nourshoreibah@users.noreply.github.com>
Copilot AI changed the title Update review bot to mark PR approved after one approval Update PR review bot to complete on first approval while still requesting two reviewers Aug 20, 2026
Copilot AI requested a review from nourshoreibah August 20, 2026 00:59
@nourshoreibah
nourshoreibah marked this pull request as ready for review August 20, 2026 01:00
github-actions Bot added a commit that referenced this pull request Aug 20, 2026
github-actions Bot added a commit that referenced this pull request Aug 20, 2026
@nourshoreibah
nourshoreibah merged commit cd88cf9 into main Aug 20, 2026
19 of 20 checks passed
@nourshoreibah
nourshoreibah deleted the copilot/update-pr-review-bot-approval branch August 20, 2026 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants