Ses s3 initmodules

[chnnick]

ℹ️ Issue

Part of #140 using module initialization errors instead of having checks for environment variables happen in the services.

📝 Description

Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.

Briefly list the changes made to the code:

1. Made SES and S3 modules implement the onmoduleinit class
2. Hardcoded in the env variables that SES and S3 previously checked for within the service (S3) or factory (SES) checked on module initialization
3. if env variables are missing (and in ses case, the send_automated_emails env variable is set to true), throws error/fails startup

✔️ Verification

What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.

Provide screenshots of any new components, styling changes, or pages.

🏕️ (Optional) Future Work / Notes

• [!IMPORTANT] I am not sure if these are the same, but S3 uses AWS_ACCESS_KEY, and AWS_SECRET_KEY as values, but SES uses AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY. Should these be normalized???
• Cognito PR has a shared utils/env.ts file (can be renamed) that can be used instead of the existing check:

if (!value || value.trim().length === 0) {
        throw new Error(`Missing required environment variable: ${name}`);
      }
    }

• Added module tests for these modules since they are supposed to fail/throw errors instead of just warn like Cognito's, but I dont know of any other modules that use module tests so can delete if unneccessary

[maxn990]

looks great, one quick thing then feel free to merge! thanks!

[dburkhart07]

a few things i think would be good to clear up now that we are doing this. thanks in advance!

[dburkhart07]

like the cognito module does, i think we should add a logger here, and just throw a warning not an error (same with ses). i know we were throwing an error beforehand, but i think that was not good in practice.

[dburkhart07]

nit: for consistency, can we just name this AWSSESModule?

[dburkhart07]

we need to add an optional check here i think. the factory runs during dependency injection, so we could face issues here if this is unset.

[dburkhart07]

I just realized i think this will throw an error the way we have the environment variable creation setup. we should:

1. Put in the README for s3 (or on line 5 in the module) to add all env bucket names into that const as well)
2. In here, read the bucket names from the process.env and assign them to this.bucketNames. If we do step 1, we shouldnt need to throw any errors here, since the env variables will not missing so long as they are added to the const. We can then restructure the loop like this:

for (const bucket of Object.values(S3Buckets) as unknown as S3Buckets[]) {                                                                                                                 
    this.bucketNames[bucket] = process.env[`AWS_${bucket}_BUCKET_NAME`] ?? '';                                                                                                             
  } 

Making sure the user is aware in the README that all env vars need to follow the AWS_bucket_name_BUCKET_NAME format (likely just an update to example.env