Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 3 | implement and rewrite-test with jest by Tobias-Amaechina · Pull Request #1476 · CodeYourFuture/Module-Structuring-and-Testing-Data

Tobias-Amaechina · 2026-07-06T22:14:15Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

1 Full Implementation of getCardValue
Added complete logic for parsing card strings.

Validates both rank and suit according to the rules of a standard 52‑card deck.

Returns correct numerical values:

Ace → 11

Face cards → 10

Number cards → their numeric value

Throws descriptive errors for invalid input.

Rewritten and Expanded Test Suite
Replaced legacy assertions with clearer, structured tests.

Added coverage for:

All valid card types

All face cards

Ace handling

Numeric cards

Error cases (invalid rank, invalid suit, missing suit, missing rank, non‑string input, malformed card formats)

Ensures the function behaves correctly across edge cases.

…intor is positive

…r -ve

…ator are equal

…ominator

…umerator

…nator is positive

…nator is negative

…are -ve, however the numerator is less than denominator in absolute terms

LonMcGregor

Good work and good test cases. this task looks complete!

github-actions · 2026-07-13T09:57:39Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-07-13T09:57:39Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-3/1-implement-and-rewrite-tests/implement/1-get-angle-type.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

Tobias-Amaechina added 30 commits June 29, 2026 19:48

Implement the condition to execute and determines acute angle

529ed10

Wrote test to check for acute angle lower refernce

10fee33

Wrote test to check acute angle in the mid range

a593587

Wrote test for the upper limit acute angle

e97765d

Implemented a function to check if angle is right angle

4d173e0

wrote a test that check right angle

f1e2785

Implements condition to execute Obtuse angle

0d0ea09

wrote test to check obtuse angle just above right angle

cd0ed46

Wrote a test to check mid range obtuse angle

800eb91

wrote test for upper limit obtuse angle

e7d9706

Implemented statement to execute straight angle

49b67a4

Wrote a test to check for straight angle

3f44e88

Implemented statement to execute reflex angle condition

4533447

Wrote test to check the lower limit of Reflex angle

4e66775

Wrote test to check mid range reflex angle

8c83316

Wrote test to check the upperlimit of reflex angle

142a377

Implemented statement to execute lower invalid angle

d9af0e9

Wrote test to check lower invalid angle

06da082

Implemented statement to execute upper limit invalid angle

792abfe

Wrote a test to check when angle is zero

7c1314f

Wrote a test to check for angle 360

b63764b

Wrote a test to check when angle is over 360

1580dbf

print a statement to say that all test passed

925c0c9

Implement the statement to execute the logic

ce30492

wrote a test to check improper fraction

74c61b0

wrote a test to check when numerotor is zero and denominator 5

cf6edc1

Wrote a test for Improper fraction with denomintor having zero value

7b66cae

Wrote a test for proper fraction when numerator is negative and denom…

4b4e850

…intor is positive

wrote a test for proper fraction with denominator -ve and numerator +ve

730a4dd

wrote a tesch for a proper fraction with both nuerator and denominto…

06966ef

…r -ve

Tobias-Amaechina added 24 commits July 5, 2026 01:33

Wrote a test suit to check for special case when numerator is 0

b850940

Wrote a test suit to check for special cases when numerator & denomin…

3ae5e6c

…ator are equal

Wrote a test suit to check for when the numerator is greater than den…

5241806

…ominator

wrote a test suit to check for when denominator is greater than the n…

0acbb55

…umerator

Wrote a test suit to check for when numerator is negative and denomi…

6c3c897

…nator is positive

wrote a test suit to check for when numerator is positive and denomi…

bd92f23

…nator is negative

Wrote a test suit to check for when both denominator and numerators …

adbdbf5

…are -ve, however the numerator is less than denominator in absolute terms

Wrote a test suite to return a card numeric value in this card 2

7e4bc9b

Rewite test for getcardValue

bbe10f9

rewrote test to check and print the numeric value of card when 4

7695832

rewrote test to check and print the numeric value of card when 5

9f51172

rewrote test to check and print the numeric value of card when 6

a257497

rewrote test to check and print the numeric value of card when 7

e23e51d

rewrote test to check and print the numeric value of card when 8

c5ccd5d

rewrote test to check and print the numeric value of card when 9

be6cdbc

rewrote test to check and print the numeric value of card when 10

84ffbfe

rewrote test to check and print the numeric 10 when given a J card

41b3b3b

rewrote test to check and print the numeric 10 when given a Q card

168aabe

rewrote test to check and print the numeric 10 when given a K card

cf96c14

rewrote test to check an invalid card when rank is numeric 1

32055e1

rewrote test to check an invalid suit

55b402f

rewrote test to check an invalid card

52878f1

rewrote test to check an invalid card format

fb62cf4

Update Jest tests for getCardValue

6ae0956

Tobias-Amaechina added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jul 6, 2026

LonMcGregor reviewed Jul 13, 2026

View reviewed changes

LonMcGregor added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jul 13, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 3 | implement and rewrite-test with jest#1476

Birmingham | 26-ITP-May | Tobias Amaechina | Sprint 3 | implement and rewrite-test with jest#1476
Tobias-Amaechina wants to merge 81 commits into
CodeYourFuture:mainfrom
Tobias-Amaechina:coursework-sprint-3-implement-and-rewrite

Tobias-Amaechina commented Jul 6, 2026

Uh oh!

LonMcGregor left a comment

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

Tobias-Amaechina commented Jul 6, 2026

Self checklist

Changelist

Uh oh!

LonMcGregor left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

github-actions Bot commented Jul 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants