You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice, minimal fix. The extraction of shouldAnimateChatHeader into its own pure function in cli/src/utils/chat-header-animation.ts is the right call — it's independently testable and keeps chat-header.tsx unchanged in structure (single line diff). Tests in chat-header-animation.test.ts cover the three meaningful branches (Freebuff-off, Codebuff-on, and inactive-in-either-case), which is proportionate to the size of the change.
A couple of things a maintainer will likely want confirmed before porting:
Confirm IS_FREEBUFF is genuinely a build-time/product flag already used elsewhere in cli/src/utils/constants.ts — the diff assumes it exists and is already threaded through chat-header.tsx, which it is per the import list, so this looks consistent with existing conventions rather than introducing a new product branch.
IS_FREEBUFF is the existing Freebuff build-time product flag in cli/src/utils/constants.ts; it is injected via --define/FREEBUFF_MODE and is already the flag imported by chat-header.tsx.
So I don't see a broader useSheenAnimation timing bug that this change is masking; the scoped behavior matches the reported request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1035
Validation
tarandreact-dom/serverdeclarations; no errors from changed filesgit diff --check: passed