fix(cli): support ctrl-arrow word navigation - #1108
Conversation
|
Nice, focused change. Extracting A couple of things worth double-checking before this lands in the private tree:
Overall this is well-scoped, in-scope (cli/), and the tests are appropriate. Recommending it be ported, pending a maintainer's quick check on point 1 above. |
|
Checked the navigation handler end-to-end. There is no second Ctrl+Left/Right binding after the new word-navigation block: the later branches are Cmd+Left/Right (line boundaries), Ctrl+A/E, Ctrl+Home/End, Ctrl+B/F, and unmodified arrows. Because the word-navigation branch returns immediately, plain Ctrl+Left/Right is handled exactly once. I also addressed the modifier-question in 9400ea0 with an inline comment: |
Summary
Fixes #847
Validation
tarandreact-dom/serverdeclarations remaingit diff --checkpassesmultiline-input.tsx; the base file has the same result