fix(cli): declare release and DOM test dependencies - #1109
fix(cli): declare release and DOM test dependencies#1109c8dhjp4tyv-bit wants to merge 2 commits into
Conversation
|
Good catch if A few things worth double-checking before this is ported:
Overall this is a small, plausible dependency-hygiene fix and easy to verify by re-running |
|
Checked the two dependency concerns against the release layout.
The lockfile major changes are also scoped to the new tar 7 graph: tar gets The PR head also has a Public CI workflow run, but GitHub currently reports it as |
Summary
tar, which the release launcher and wrapper safety tests import in the private CLI workspace@types/react-dom, which the CLI's server-rendering tests require for typecheckingbun.lockwith the minimal dependency graph changestarintentionally remains a CLI workspace devDependency: the actual published wrappers (cli/release,cli/release-staging, andfreebuff/cli/release) each already declaretarin their own runtimedependencies.Validation
tar.candrenderToStaticMarkupresolvetar-fs/chownr@1.1.4,lru-cache/yallist@4.0.0) rather than upgrading them transitivelygit diff --checkpassesaction_required, so there is no completed GitHub CI result to claim yet