Skip to content

Consolidate Classic into Ledger and protect drafts and local APIs - #262

Open
Coding-Dev-Tools wants to merge 18 commits into
codex/dashboard-local-audit-20261011from
ui/ledger-only
Open

Coding-Dev-Tools wants to merge 18 commits into
codex/dashboard-local-audit-20261011from
ui/ledger-only

Conversation

@Coding-Dev-Tools

@Coding-Dev-Tools Coding-Dev-Tools commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

Classic capabilities now live in Ledger, /classic redirects to it, and token-free dashboard/graph APIs enforce declared hosts and complete browser origins (scheme, hostname and port).

Stack: #260 (Antigravity Spec Crawl/Spec Studio) → #261 (local dashboard/graph improvements) → this PR (Claude Desktop Ledger consolidation/security). Each PR retains its own diff. The integrated branch preserves scoped audits, camera ownership and asynchronous editor/selection guards.

Hidden drafts survive description/copy/import and maintenance refreshes. Rename, merge, delete and selected-record moves confirm before discarding; pending workspace mutations block stale edits, reflect the confirmed owner, and respect newer navigation. Reorder writes follow gesture order. Graph keyboard navigation, relations and legends follow visible scope, retain selection, and reuse unchanged snapshots. Superseded Timeline filtering runs before limits with world/system-time gates; normal and keyword results display chronological history and accurate current/past/future states.

Spec Studio uses DOM/SVG operations under strict CSP. Windows Node harnesses use UTF-8, portable paths and temporary files. HTTP readers treat watchdog interruption as a timeout even before a coarse clock tick, while retaining only provably complete credential-rotation bodies.

Validation covers the full offline Python and Chromium gates, scoped/draft/graph/transport regressions, all nine offline eval gates, Ruff, Pyright, commercial boundary, MCP contract and CSP checks. Remote CI qualifies the current head separately. Immutable evidence binds 585 Python/dataset inputs, with matching SVG/PNG provenance and README chart/methodology links pinned to the source commit.

Original Claude session: https://claude.ai/code/session_01QRXYjdLRbDr9oEUU4qdZ2m

Coding-Dev-Tools and others added 2 commits October 12, 2026 02:24
The dashboard now has one interface. Each capability Classic had was rebuilt
into the Ledger view where people look for it, then Classic was removed:

- Library: Markdown rendering (DOM-only renderer, never parses HTML) with a
  Write/Preview editor, unsaved-changes guard and Ctrl/Cmd+S; word-level
  history diffs; per-memory audit trail; drag and Alt+Arrow ordering; one
  Import menu (Quick import of files, folders or a server path, document
  import, code indexing and PostgreSQL schema import).
- Ask: per-result retrieval scores. Home: memory health and the selected
  project's last-session handoff (GET /api/proactive gains `repo`).
- Explore: colour by cluster, type or connections, palettes, editable type
  colours, a legend, an entity and relation explorer, keyboard navigation.
- Activity: bi-temporal Timeline cards with a superseded-only filter
  (replacing the Supersessions tab), receipt-chain status, packed-context
  accounting.
- Settings: workspace Describe, Copy, Merge, Export and Delete; plan status
  and plan-aware hosted messages; automation run status and proposals.
- Everywhere: connection and semantic-search banners, an accessible in-page
  dialog instead of native confirm/prompt, Solarized and Sepia themes.

Removed: engraphis/classic_assets, the duplicate engraphis/static tree, the
dashboard switcher, the graph compat adapter, and the Marked and DOMPurify
copies. /classic redirects to /. Shipped dashboard assets drop from 3.51 MB
in three trees to 1.85 MB in one.

Hardening found on the way: the zero-config API refuses requests a browser
marks as cross-site unless they passed a CORS preflight; the Markdown
renderer is linear on adversarial input; dialogs drop bidi controls; secure
erase sends its required confirmation; a stalled graph download no longer
blocks Reload; the CSP release gate covers Ledger and every first-party
script. Tests, docs, packaging and the public offline evidence artifact are
updated to match (fixture results unchanged).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QRXYjdLRbDr9oEUU4qdZ2m
Without ENGRAPHIS_API_TOKEN the dashboard trusts loopback peers. A website
that points its own name at 127.0.0.1 (DNS rebinding) becomes same-origin
with that name, so its requests came from a loopback peer, passed every
Origin check and could read or write the whole /api surface.

- The zero-config gate now also checks Host: it accepts exactly
  `localhost`, IP literals (an address cannot be rebound), the bind host,
  the ENGRAPHIS_DASHBOARD_URL host and the new ENGRAPHIS_ALLOWED_HOSTS
  names. `localhost.` and `*.localhost` are refused because some resolvers
  send them to DNS. Token mode is unchanged.
- The check covers the `/dashboard/review` routes as well as `/api`; `/mcp`
  keeps the SDK's own Host allow-list.
- The read-only graph server (engraphis-graph-server) applies the same
  check when it runs without a token.
- The cross-site guard no longer lets a header vouch for another site's
  page: with ENGRAPHIS_CORS_ORIGINS=* any page could pass the preflight
  and send the dashboard's header.
- Ledger shows the server's reason when a request is refused instead of
  reporting the server as unreachable.

The helpers live in engraphis/netutil.py and are unit-tested; the public
offline evidence artifact is re-exported for the new sources (fixture
results unchanged).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QRXYjdLRbDr9oEUU4qdZ2m
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-12T17:49:28.991651Z ec71481 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Coding-Dev-Tools
Coding-Dev-Tools changed the base branch from main to codex/dashboard-local-audit-20261011 October 12, 2026 13:59

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 679dcbb1f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/dashboard_assets/ledger.js Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 22ce45e0da

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/dashboard_assets/ledger.js Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1af2b2224

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/dashboard_assets/ledger.js Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f1f85a4925

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/dashboard_assets/ledger.js Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: de8c168b95

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/dashboard_assets/index.html Outdated
Comment thread engraphis/dashboard_assets/ledger.js Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 606d3e579b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/dashboard_assets/engraphis-graph.js Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 95999cb42e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/dashboard_app.py Outdated
Comment thread engraphis/routes/v2_api.py

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f07db1ff95

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/core/store.py Outdated
@Coding-Dev-Tools Coding-Dev-Tools changed the title Fold Classic into Ledger and refuse DNS-rebinding hosts Consolidate Classic into Ledger and protect drafts and local APIs Oct 12, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7a1b05e8da

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread engraphis/dashboard_assets/ledger.js

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant