Repository navigation
[Phase 2] Regression suite on Java 21 / Boot 3.5 + Next 15: REST/GraphQL/repository/migration/serialization/unit tests, frontend Vitest regression, Selenium critical path, regression.yml - #231
Merged
devin-ai-integration[bot] merged 3 commits intoOct 8, 2026
Merged
Conversation
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
…ialization/unit), Selenium critical path, regression.yml
… fixtures, DGS 10 introspection split, MOCK web env for rollback test)
…ion, markdown, session, route smoke) under frontend/__tests__/regression
devin-ai-integration
Bot
force-pushed
the
devin/1791491209-modernization-regression-suite
branch
from
October 8, 2026 21:22
700e7a0 to
31f79a4
Compare
devin-ai-integration
Bot
merged commit Oct 8, 2026
48e7828
into
devin/1791491209-modernization-integration
10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cross-cutting regression suite (session 6), now rebased onto the fully migrated integration branch (Java 21 / Boot 3.5.16 / jakarta / DGS 10 /
java.time+ Next 15 / React 19 / Vitest 5). Three commits, no production code (src/main/**), nobuild.gradle/gradle.yml/ frontend config changes, no existing test files touched.Backend (
src/test/java/io/spring/regression/**,selenium/**) — 181 new JUnit 5 tests on top of the other sessions' 203 → 384 tests, 0 failures, 94.2% JaCoCo instruction coverage (threshold 0.80 untouched, no new exclusions):regression/RegressionIntegrationTestBase:@SpringBootTest(RANDOM_PORT)+ REST-Assured against the real SQLite DB with the Flyway seed; fresh file-backed DB per class via@DynamicPropertySource(build/regression-db/regression-<uuid>.db), port via@Value("${local.server.port}").regression/rest/*ContractTest+SecurityMatrixTest: every REST endpoint (status, envelope, field types, 422 field errors, 404, malformed JSON, ownership 403) and the 401/403 matrix (missing header,Token/Bearer/raw/empty/garbage/tampered/unknown-subject tokens).regression/graphql/GraphqlContractTest: Query/Mutation introspection, queries/mutations, cursor pagination, filters, auth errors, malformed documents.regression/repository/*,regression/migration/FlywayMigrationTest,regression/serialization/JsonSerializationTest,regression/unit/*: CRUD/constraints/rollback, Flyway V1+V2 on a temp SQLite file (schema, indexes, seed counts), ISO-8601 UTC millisZ/ root-unwrapped requests / nullbio/image, domain + DTO + pager unit tests.selenium/pages/*+selenium/tests/CriticalPathSmokeTest: home feed, wrong-password error, register → login → create article → view → comment → favorite → logout (headless Chrome,./gradlew seleniumTest, excluded fromtest).Frontend (
frontend/__tests__/regression/**, 7 files, 41 tests) on top of the frontend session's 10 Vitest files (110 tests) → 151 tests, 0 failures; coverage 94.23/89.38/88.88/95.52 → 97.42% statements / 92.24% branches / 94.15% functions / 98.72% lines (thresholds 85/80/80/85 untouched). Files:forms,api,context,pagination,markdown,session,routes.regression.test.ts(x)— RegisterForm/LoginForm/SettingsForm error paths anderrors.bodynesting, API client URL encoding/default paging/auth headers/4xx-as-return-value,PageContext/PageCountContextfunctional updates + sessionStorage rehydration,getPageInfo/getRange/Pagination controls (<</</>/>>+ SWR revalidate), markdown GFM + DOMPurify sanitising,fetcher/storage/ArticlePreview favorite/profile follow-unfollow/ProfileTab, and route smoke throughpages/_app(guest vs authenticated navbar, login/register pages).CI:
.github/workflows/regression.yml—backend-gate(JDK 21 full gate),frontend-gate(Node 22npm ci/lint/typecheck/test/build, uploadsfrontend/coverage),e2e-selenium(startsbootRun+next start, runsseleniumTest, uploadsbuild/reports/selenium).Migration notes
d39a869): JodaDateTime→java.time.InstantinRegressionFixtures;RepositoryTransactionRollbackTestmoved fromWebEnvironment.NONEtoMOCKbecause Spring GraphQL'sGraphQlHttpConfigurationrequires aWebGraphQlHandlerunder Boot 3.5; GraphQL introspection split into two requests (Query fields / Mutation fields) to stay under graphql-java's "good faith introspection" guard; unauthenticatedmenow assertsdata.me == nullwith noerrors(DGS 10 behaviour).javax.*,@MockBeanor@LocalServerPortin the new tests; REST-Assured 5.5 / Selenium 4.33 / TestNG 7.11 APIs only.test/setup.ts,test/utils.tsx(renderWithProviders),test/fixtures.ts,test/mockRouter.ts; the only module-level mock added isvi.mock("swr", …)formutateinpagination.regression.test.tsx.POST /users→ 201,POST /articlesandPOST /articles/{slug}/comments→ 200; article JSON exposesid/cursor;POST /users/loginwith a bad password → 422{"message":"invalid email or password"}(the Next 15toErrorMapfallback now renders it, so the Selenium wrong-password test passes).Verification
On the rebased branch (integration head with #227/#228/#229/#230 merged):
PR CI (
gradle.ymlBackend/Frontend +regression.ymlbackend-gate/frontend-gate/e2e-selenium): all 5 checks green.Known production findings (not fixed here — outside this PR's ownership)
POST /users/loginbad credentials returns{"message": …}rather than the{"errors": {...}}envelope used everywhere else.ArticleMapper.updatedoes not writeupdated_at.updateUserwithout auth returnsdata: nullwith noerrorsentry (other mutations raiseAuthenticationException).RegisterFormtreatsstatus !== 200as an error path althoughPOST /usersreturns 201 (harmless becausetoErrorMapof a success body is{}, but the branch is wrong).getPageInfoyields an empty page window whentotal < limit(no numbered page is rendered for a single short page); pinned as current behaviour.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/4da7f7c2d222447884300eea943396e3
Open in Devin Desktop: https://partner-workshops.devinenterprise.com/desktop/session/4da7f7c2d222447884300eea943396e3?variant=devin
Requested by: @mbatchelor81