Repository navigation
Prepare WebSphere-exit "before" estate: baseline, parity harness, unit tests, synthetic tWAS/AIX ops, inventory, CI - #1
Merged
Conversation
…t tests, synthetic tWAS/AIX ops, inventory, docs, CI
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR prepares DayTrader 3 (Java EE 6) as the starting point for a WebSphere → Spring Boot on ECS Fargate demo. It adds no Spring Boot code, no target Dockerfile and no Terraform; those are for the live demo.
docs/BASELINE.md): the app builds with JDK 8 (the POMs target Java 7) and runs unchanged onicr.io/appcafe/websphere-liberty:full-java8-ibmjava-ubiwith the repo's ownserver.xml, an embedded Derby DB, and the database built and seeded at startup. Only the build was fixed: the rootpom.xmlnow buildsdaytrader3-ee6-wlpcfgbefore the EAR module (itscleanused to delete the copied EAR and Derby jar), andmaven-ear-pluginis pinned to 2.8. No app code is changed. Three quirks are kept and recorded on purpose: an invalid login returns HTTP 500, the account page showsTotal Orders: 0after trades, andGET /rest/addresses/{name}returns 415.parity/): 13 HTTP scenarios (login, home, quotes for 3 symbols, register, buy, sell, portfolio after trades, account update, invalid login, logout, 3 REST). They run with a fixed seed.compare.py --targetwriteswork/parity/report.mdand exits non-zero on any diff.rules.yamland are explained inNORMALIZATION.md(timestamps, IDs, session IDs, per-run users, decimals).checksverifies the money from raw values instead, e.g.cash debit == quote price × qty + 24.95.daytrader3-ee6-ejbcoveringFinancialUtils,TradeConfig.setConfigParamand the entity JPA mapping. Tests compile at Java 8; production code stays at Java 7. The entities have nojavax.validationannotations, so the entity tests check the JPA mapping (tables, ID columns, equality by ID) rather than bean validation.legacy-ops/(synthetic, never executed): wsadmin Jython (Db2 type 4 provider,jdbc/TradeDataSource, J2C aliases, MQjms/TradeBrokerQCF, queue and topic, activation specs for both MDBs, shared library,AdminApp.install) and AIX ksh scripts (start/stop wrappers,ulimit, cron log rotation). They use the app's real JNDI names. The optional Liberty + IBM MQ variant was not added; the README explains why, including the license gap.tools/ws_inventory.pygeneratesdocs/WEBSPHERE_INVENTORY.md(146 rows, replacement columnTBD). CI fails if the file is stale. It finds 0com.ibm.*imports outside the project's own package, i.e. no WebSphere-proprietary API use.docs/TARGET_STATE.md(Java 21, Spring Boot 3.3, Aurora PostgreSQL, SQS, Thymeleaf decision,infra/terraform/{network,ecs,alb,rds}, plan only),docs/LAB.md(3 demo prompts),AGENTS.mdand.agents/skills/daytrader-parity/SKILL.md.make parityand uploads the reports.Review focus: the normalisation rules (
parity/rules.yaml), since they decide what "parity" means for the live demo.Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/cc4b8554a6ee49b7b75e443b13bcb116
Open in Devin Desktop: https://partner-workshops.devinenterprise.com/desktop/session/cc4b8554a6ee49b7b75e443b13bcb116?variant=devin
Requested by: @sumitshatwara