Skip to content

Prepare WebSphere-exit "before" estate: baseline, parity harness, unit tests, synthetic tWAS/AIX ops, inventory, CI - #1

Merged
sumitshatwara merged 2 commits into
masterfrom
devin/1793778194-websphere-exit-estate
Nov 4, 2026
Merged

sumitshatwara merged 2 commits into
masterfrom
devin/1793778194-websphere-exit-estate

Conversation

@devin-ai-integration

Copy link
Copy Markdown

Summary

This PR prepares DayTrader 3 (Java EE 6) as the starting point for a WebSphere → Spring Boot on ECS Fargate demo. It adds no Spring Boot code, no target Dockerfile and no Terraform; those are for the live demo.

make up && make build && make run && make parity TARGET=http://localhost:9083/daytrader   # 13/13 PASS
  • Baseline (docs/BASELINE.md): the app builds with JDK 8 (the POMs target Java 7) and runs unchanged on icr.io/appcafe/websphere-liberty:full-java8-ibmjava-ubi with the repo's own server.xml, an embedded Derby DB, and the database built and seeded at startup. Only the build was fixed: the root pom.xml now builds daytrader3-ee6-wlpcfg before the EAR module (its clean used to delete the copied EAR and Derby jar), and maven-ear-plugin is pinned to 2.8. No app code is changed. Three quirks are kept and recorded on purpose: an invalid login returns HTTP 500, the account page shows Total Orders: 0 after trades, and GET /rest/addresses/{name} returns 415.
  • Parity harness (parity/): 13 HTTP scenarios (login, home, quotes for 3 symbols, register, buy, sell, portfolio after trades, account update, invalid login, logout, 3 REST). They run with a fixed seed. compare.py --target writes work/parity/report.md and exits non-zero on any diff.
    • Normalisation rules live in rules.yaml and are explained in NORMALIZATION.md (timestamps, IDs, session IDs, per-run users, decimals).
    • Decimals are masked because the server's RNG is clock-seeded and can't be set over HTTP. Each scenario's checks verifies the money from raw values instead, e.g. cash debit == quote price × qty + 24.95.
    • The suite still passes 13/13 after re-seeding the DB.
  • Unit tests: 24 JUnit 5 tests in daytrader3-ee6-ejb covering FinancialUtils, TradeConfig.setConfigParam and the entity JPA mapping. Tests compile at Java 8; production code stays at Java 7. The entities have no javax.validation annotations, so the entity tests check the JPA mapping (tables, ID columns, equality by ID) rather than bean validation.
  • legacy-ops/ (synthetic, never executed): wsadmin Jython (Db2 type 4 provider, jdbc/TradeDataSource, J2C aliases, MQ jms/TradeBrokerQCF, queue and topic, activation specs for both MDBs, shared library, AdminApp.install) and AIX ksh scripts (start/stop wrappers, ulimit, cron log rotation). They use the app's real JNDI names. The optional Liberty + IBM MQ variant was not added; the README explains why, including the license gap.
  • Inventory: tools/ws_inventory.py generates docs/WEBSPHERE_INVENTORY.md (146 rows, replacement column TBD). CI fails if the file is stale. It finds 0 com.ibm.* imports outside the project's own package, i.e. no WebSphere-proprietary API use.
  • Docs and steering: docs/TARGET_STATE.md (Java 21, Spring Boot 3.3, Aurora PostgreSQL, SQS, Thymeleaf decision, infra/terraform/{network,ecs,alb,rds}, plan only), docs/LAB.md (3 demo prompts), AGENTS.md and .agents/skills/daytrader-parity/SKILL.md.
  • CI: Travis is replaced by GitHub Actions, which runs the Maven build with unit tests, checks the inventory, starts Liberty, runs make parity and uploads the reports.

Review focus: the normalisation rules (parity/rules.yaml), since they decide what "parity" means for the live demo.

Link to Devin session: https://partner-workshops.devinenterprise.com/sessions/cc4b8554a6ee49b7b75e443b13bcb116
Open in Devin Desktop: https://partner-workshops.devinenterprise.com/desktop/session/cc4b8554a6ee49b7b75e443b13bcb116?variant=devin
Requested by: @sumitshatwara

…t tests, synthetic tWAS/AIX ops, inventory, docs, CI
@devin-ai-integration

Copy link
Copy Markdown
Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@sumitshatwara
sumitshatwara merged commit 2cefe4b into master Nov 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant