retrofit: reverse-spec notificatie-engine partial (5 REQs / 31 methods, 57 deferred)#1788
Open
rubenvdlinde wants to merge 1 commit into
Open
retrofit: reverse-spec notificatie-engine partial (5 REQs / 31 methods, 57 deferred)#1788rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
…s, 57 deferred) Reverse-engineers 5 net-new REQs from observed behaviour in the annotation-driven notification dispatcher and its supporting services. First pass of a multi-pass retrofit covering the 88-method cluster from the notificatie-engine coverage scan. New REQs (notificatie-engine#REQ-101..REQ-105): - REQ-101: Schema-annotation pipeline orchestration (dispatch, matches, broadcast vs per-recipient fan-out) - REQ-102: Recipient resolution across 6 kinds with userExists fail-closed against attacker-controlled object data - REQ-103: Token-bucket rate limiter per (rule, recipient) with per-rule override, kill switch, fail-open semantics - REQ-104: Per-(rule, recipient) debounce coalescer with windowSeconds + maxEvents flush trigger - REQ-105: Idempotency-key claim-first dedup with unique-index serialisation under concurrency Method coverage (31 methods this pass): - AnnotationNotificationDispatcher (16 methods) - RateLimiter (6 methods) - NotificationCoalescer (8 methods) - AnnotationNotificationListener (3 methods) - RecipientResolverInterface (1 method) Deferred to future passes (57 methods, 10 follow-on REQs sketched in tasks.md future-pass:next): channel emit surfaces, locale/i18n resolution, organisation pinning, subscription gating, annotation validator + installer, scheduled/threshold/batch jobs, history query API, VNG envelope, INotifier renderer side. Confirmed: notificatie-engine#ISO-8601 is NOT a REQ — appears only as a scenario-token referring to ISO 8601 timestamp format at lines 138 and 319 of the existing spec.
rubenvdlinde
requested review from
Rem-Dam,
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
May 24, 2026 19:15
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 162/162 | |||
| npm | ✅ | ✅ 532/532 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-24 19:17 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverse-engineers 5 net-new REQs from observed behaviour in the annotation-driven notification dispatcher and its supporting services. This is pass 1 of N for the 88-method
notificatie-engineBucket 2a cluster — 31 methods annotated, 57 deferred to follow-on passes.Ghost change:
openspec/changes/retrofit-2026-05-24-notificatie-engine/New REQs
x-openregister-notifications→ trigger match → broadcast / per-recipient fan-out)users/field/groups/relation/object-acl/expression) withuserExists()fail-closed(rule, recipient)with per-rule override + kill switch (notification_rate_limit_enabled)(rule, recipient)debounce coalescer withwindowSeconds+maxEventsflush(notification_slug, idempotency_key)unique index as concurrency serialisation pointAnnotated files (this pass)
lib/Service/Notification/AnnotationNotificationDispatcher.php— 16 methodslib/Service/Notification/RateLimiter.php— 6 methodslib/Service/Notification/NotificationCoalescer.php— 8 methodslib/Listener/AnnotationNotificationListener.php— 3 methodslib/Service/Notification/RecipientResolverInterface.php— 1 methodAll edits are pure
@specPHPDoc tag additions; no code behaviour changed.Deferred (57 methods, 10 follow-on REQs)
Sketched in
tasks.mdunderfuture-pass:next.Notes
notificatie-engine#ISO-8601confirmed NOT a REQ — scenario-token only.userExists()gate is the OWASP A01 / CWE-863-adjacent guard against attacker-controlled object-data field values.openspec validate --strictpasses.Source:
/tmp/or-scan/rspec-cluster-notificatie-engine.json(88 methods, 19 files)