Repository navigation
add two sample test plot of histograms - #23
Open
ConnorStoneAstro wants to merge 2 commits into
Open
ConnorStoneAstro wants to merge 2 commits into
ConnorStoneAstro wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 98.38% 97.84% -0.55%
==========================================
Files 4 4
Lines 621 696 +75
==========================================
+ Hits 611 681 +70
- Misses 10 15 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The diagnostic needs corrected landmark weighting, complete final-bin rendering, and bounded permutation-label allocation.
3 open issues
What changed in this PR
Adds a distance-histogram diagnostic to help interpret PTED results by showing within-sample and cross-sample distance distributions alongside permutation-based uncertainty bands.
Changes:
- Adds standalone plotting and optional plotting through
pted, reusing the prepared test data. - Tests component counts, figure generation, p-value preservation, and singleton handling.
- Documents how to request and interpret the diagnostic.
| File | Description |
|---|---|
| tests/test_utils.py | Adds histogram counting and plotting tests. |
| src/pted/utils.py | Implements component histograms and permutation bands. |
| src/pted/pted.py | Adds plotting options and shares test preparation with the diagnostic. |
| README.md | Explains diagnostic usage and interpretation. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.