Skip to content

add two sample test plot of histograms - #23

Open
ConnorStoneAstro wants to merge 2 commits into
mainfrom
diagnosticplot
Open

ConnorStoneAstro wants to merge 2 commits into
mainfrom
diagnosticplot

Conversation

@ConnorStoneAstro

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI balanced review requested due to automatic review settings October 22, 2026 19:37
@codecov-commenter

codecov-commenter commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.42105% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.84%. Comparing base (54999ff) to head (0f5a455).

Files with missing lines Patch % Lines
src/pted/utils.py 93.05% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   98.38%   97.84%   -0.55%     
==========================================
  Files           4        4              
  Lines         621      696      +75     
==========================================
+ Hits          611      681      +70     
- Misses         10       15       +5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The diagnostic needs corrected landmark weighting, complete final-bin rendering, and bounded permutation-label allocation.

3 open issues
What changed in this PR

Adds a distance-histogram diagnostic to help interpret PTED results by showing within-sample and cross-sample distance distributions alongside permutation-based uncertainty bands.

Changes:

  • Adds standalone plotting and optional plotting through pted, reusing the prepared test data.
  • Tests component counts, figure generation, p-value preservation, and singleton handling.
  • Documents how to request and interpret the diagnostic.
File Description
tests/​test_utils.py Adds histogram counting and plotting tests.
src/​pted/​utils.py Implements component histograms and permutation bands.
src/​pted/​pted.py Adds plotting options and shares test preparation with the diagnostic.
README.md Explains diagnostic usage and interpretation.

Review effort: Balanced

Comment thread src/pted/utils.py Resolved
Comment thread src/pted/utils.py Resolved
Comment thread src/pted/utils.py Resolved

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants