Repository navigation
fix(review): preserve semantic leaf from retry regressions - #2564
seonghobae wants to merge 89 commits into
Conversation
…canning Also fixes trivy-fs and pip-audit CI security failures by updating test fixtures and dependency pins.
…canning Also fixes trivy-fs and pip-audit CI security failures by updating test fixtures and dependency pins. Triggered CI retry for async failure.
…canning Also fixes trivy-fs and pip-audit CI security failures by updating test fixtures and dependency pins. Cargo update complete.
Preserve the concurrent last-label parser tests, correct their verification-label fixture, and inherit the complete PyJWT 2.15.0, urllib3 2.8.0, and PyO3 0.29.2 owner repair without a leaf copy.
…canning Also fixes trivy-fs and pip-audit CI security failures by reverting out-of-scope dependency changes and preserving only parser changes.
Preserve the concurrent #2543 lineage while inheriting the complete parser/security/coverage successor. The effective leaf delta is the rfind implementation plus corrected last-label regression tests.
Keep the latest concurrent branch history and the verified #2530-based parser/test tree. No force update or source copy.
…canning Triggering CI retry.
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head verification review for e95f0fe05e533156188a1554ae8ffe8967f4377e / tree fef72911f8074c34bd747614be934a4ae43a2976: no additional Critical or Important finding in the integrated five-path delta. Local evidence: normalizer 134/134; repository 5,335 passed, 10 skipped, 40 subtests; target statement/branch coverage 100% (788/390, zero misses/partials); public-doc coverage 100%; filtered and full Strix PASS; static checks GREEN. This is a COMMENT, not an approval. PR remains Draft / Proposed / merge HOLD pending fresh terminal hosted exact-head Checks and a qualifying independent approval.
seonghobae
left a comment
There was a problem hiding this comment.
Final exact-head evidence note for a62fe71a7573cf377da535d2dcb72e9f714b263d / tree 54cee0a6bd8a25bf54fbf454a495f7230866f2a8: this child changes only CHANGELOG and the Gap baseline to replace stale pre-integration counts with the observed 134/134, 5,335 passed / 10 skipped / 40 subtests, 100% target statement/branch/public-doc coverage, and complete Strix PASS. The executable blobs are identical to verified repair head e95f0fe0…; final docs diff passes whitespace/conflict checks. This is a COMMENT, not an approval. Draft / Proposed / merge HOLD remains mandatory pending terminal hosted exact-head Checks and an independent approval.
Exact-head linear-framing repair ready for hosted admissionCurrent authority:
Ready is review admission, not approval or merge readiness. Merge stays HOLD until terminal exact-head hosted Checks and a qualifying independent |
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head COMMENT review for 2974f7a806af50bcc64be627d37182683467b61e / tree 2fd94cfb8b41056dd7c8d3e9dfb37061f8cacd79. RCA→RED→GREEN covers quoted-control false positives, quoted-delimiter false negatives, contraction and quote-adjacency identity, exact mixed backtick runs, Markdown fence compatibility, 10,000-level decoder recursion, and same-line prefix-copy complexity. Independent read-only review required three passes; all reported Critical/Important findings were converted to executable regressions, and the final pass reports none remaining with constant copied width and linear timing. Verification: normalizer 156/156; warning-fatal repository suite 5,357 passed, 10 skipped, 40 subtests; documentation contracts 30 plus 4 subtests; compileall/diff checks pass. Local coverage tools were unavailable, so no new percentage is claimed. Hosted SAST/Security/CodeQL jobs failed before steps (steps=null, logs_url=null). This is a COMMENT, not an approval. Draft / Proposed / merge HOLD remains mandatory pending fresh hosted coverage/check evidence and a qualifying independent APPROVED review.
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head COMMENT review for 46229694e20228a1835b57a4f51d72e2f50f574c / tree 2e01ba68ff4d17255c3ffa77c902ec94907abd9f. RED 807fba4b845cba193126c1484b52e803315865a7 proves that controls in opening and closing Markdown fence delimiter lines were promoted as top-level authority. GREEN 705ac4a0a76d8160cc229e2b5e5a0337b7dfb2c9 keeps delimiter-line state through newline; the documentation child records the boundary and lifecycle. Verification: normalizer 158/158; warnings-fatal repository suite 5,359 passed, 10 skipped, 40 subtests; Gap contracts 7 plus 4 subtests; full Strix harness PASS; compileall/diff checks GREEN. Hosted exact-head CodeQL/Security/SAST runs produced no executable steps, and there is no qualifying approval. This is a COMMENT, not an approval. Draft / Proposed / merge HOLD remains mandatory.
seonghobae
left a comment
There was a problem hiding this comment.
Final exact-head COMMENT review for 420f631b3b8bc0bb3c8dae4d69134ce97d932e02 / tree c17f316f03ed99f70b5f85e828a01c81f27e5e49. This fast-forward child restores the complete CHANGELOG blob 04a5719bb1c1120831b731abd0d4b1358f631460 and Gap-baseline blob f041fc429c0db254db9fd8fac4d5fe0e3f9a0859 after the first Git Data publication truncated large command output; the final remote tree is byte-identical to the independently tested local tree. RED 807fba4b845cba193126c1484b52e803315865a7 and GREEN 705ac4a0a76d8160cc229e2b5e5a0337b7dfb2c9 remain unchanged. Fresh final-tree verification: warnings-fatal repository suite 5,359 passed, 10 skipped, 40 subtests; complete Strix harness PASS; diff and compile checks exit 0. Hosted CodeQL/SAST/Security exact-head runs remain zero-step/skipped failures, with no qualifying approval. This is a COMMENT, not an approval. Draft / Proposed / merge HOLD remains mandatory.
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head verification review for 3ecb54b896fbf4c9b7fea1bf8749c28cc558c0cd / tree 774d64261ea72c9128c1e212ca714346bc849b52.
RCA and repair evidence:
- Root tilde delimiter controls: RED
11c9c5ca…→ GREEN02f2763f…. - Blockquote/list delimiter controls: RED
0c226a15…→ GREEN3ddd3184…. - Continuation indentation plus regex ReDoS/prefix-copy: RED
f2aada37…→ final GREENe5ef765f…. - The final scanner uses a conservative fail-closed marker allowlist, evaluates one fence candidate per line, retains transparent fenced-body controls, and completes a 100,000-marker failing prefix in about 0.03 seconds.
Fresh verification:
- normalizer: 171/171
- warning-fatal repository suite: 5,372 passed, 10 skipped, 40 subtests
- Gap baseline: 7 passed plus 4 subtests
- complete Strix quick-gate: PASS
- compileall and diff check: PASS
- independent final pass: no remaining approval-evidence bypass or performance regression reproduced
Hosted exact-head runs are not passes: CodeQL 37123424136 skipped before steps; SAST 37123424140 and Security 37123424115 failed before steps, with steps=null and logs_url=null. Zero qualifying approvals remain. Keep Draft / Proposed / merge HOLD; no bypass, rerun, wake commit, or merge is justified.
seonghobae
left a comment
There was a problem hiding this comment.
Exact-head COMMENT review for 4a66f579b645bd80280fa8a73ac700f9e7cf4a33 / tree 9c507339ec6253dfb60ebad5725aa8403a4fffd2. RED on predecessor 3ecb54b8… proves default last-wins JSON decoding admitted repeated members and let a later duplicate head_sha replace stale identity before validation. GREEN applies one recursive stdlib object_pairs_hook at both pure-JSON and mixed-prose decoder boundaries and preserves the rejected artifact. Verification: normalizer 174/174; target 863 statements and 432 branches at 100% with zero partials; public-doc 100%; warning-fatal repository suite 5,375 passed, 10 skipped, 40 subtests; compileall/diff checks PASS. Independent review reports no Critical/Important/Minor finding and additionally exercises escaped-equivalent keys, nested arrays, mixed prose, Diagnostic recovery, and nested-promotion rejection. Hosted exact-head SAST 37592701515 and Security 37592701558 failed before steps; CodeQL 37592701548 skipped. Failed jobs have steps=[] and logs return 404 BlobNotFound. This is a COMMENT, not an approval. Keep Draft / Proposed / merge HOLD pending successful hosted Checks and a qualifying independent APPROVED review.
Current exact authority — 2026-10-07
4a66f579b645bd80280fa8a73ac700f9e7cf4a33.9c507339ec6253dfb60ebad5725aa8403a4fffd2, identical to the independently reviewed local tree.fix/full-suite-parser-locks-20260930@e4fcd3ad277930b02a734302d7a6d0fd9315ec14.head_shaand a later currenthead_shacould therefore replace review identity before exact-run validation.3ecb54b896fbf4c9b7fea1bf8749c28cc558c0cdproves direct duplicate-object admission and CLI identity replacement with exit 0. The minimal GREEN routes both pure-JSON and mixed-prose candidates through the standard decoder's recursiveobject_pairs_hook, rejects the first repeated name at any depth, and preserves the artifact on failure.1a38c4a2a5af08add6eabd47b8f15c3853d1d063; regressionsa826a4e0917e704fca7b7079e12bf1c703ebc7fe; CHANGELOG172566ecd7756473dbeff64f6171166c3d5d0b5c; Gap baselinebfb056ed10cfbe8c8a384f2f132a0d572d996c06.37592701515failed job112697755335; Security run37592701558failed jobs112697755933and112697756263while downstream jobs skipped; CodeQL run37592701548skipped all jobs. All three failed jobs expose zero steps and their log endpoints return 404BlobNotFound; no source failure or hosted pass is claimed.APPROVEDreview remain mandatory. No bypass, auto-merge, Force Push, destructive rebase, wake commit, predecessor closure, or source-neutral rerun is authorized.Prior exact authority — 2026-10-03
3ecb54b896fbf4c9b7fea1bf8749c28cc558c0cd.774d64261ea72c9128c1e212ca714346bc849b52, byte-identical to the independently tested local tree.fix/full-suite-parser-locks-20260930@e4fcd3ad277930b02a734302d7a6d0fd9315ec14.11c9c5ca2dce8d7ef32b078d76d7cd31101557e2→ GREEN02f2763ff08d05060c66c8d6531df1aa8e49d035; nested RED0c226a1587b089a1ab267e48ab00ec9b0b69214c→ GREEN3ddd31841b73c6d5ae8555f6c8a838cb2b5f4e55; continuation/ReDoS REDf2aada37f6aa904442105d653d1217b834d8a18f→ final GREENe5ef765fb523596fdcc683876d80bc1bc644e566; documentation child3ecb54b896fbf4c9b7fea1bf8749c28cc558c0cd.1a5fef1e82eaf97f596e28615a5e122615a2b6bd; regression testsc6d3cb4b5689134fcff89fe79596d8362aa73b01; CHANGELOGb81dc4e4025286f895ebf9c851786fa44e43cd0c; Gap baseline71bffa460973c9be33112631d61f6ab7a7377069.37123424136skipped all three jobs before steps; SAST run37123424140, job111203866780, failed before steps; Security run37123424115failed Detect changed scope and gitleaks before steps while downstream jobs skipped. Every cited job hassteps=nullandlogs_url=null. No hosted parser, security, CodeQL, model, or coverage pass is claimed; blind rerun is not warranted.APPROVEDreview remain mandatory. No bypass, auto-merge, Force Push, destructive rebase, wake commit, predecessor closure, or source-neutral rerun is authorized.Problem
Predecessor #2543 repeatedly received source-changing commits titled as CI retries. Four descendants —
ed10aad2,d1ead4ea,9d7c104b, and5e36a45a— converged on stale treed73efe793a59a1ea354e43d62d4da4fa962d1216, twice undoing an exact-tree restoration and removing eleven reviewed owner/leaf paths.Initial verified successor transfer
This creation-time topology is preserved as lineage evidence; the current authority section above supersedes its head, tree, effective delta, and lifecycle.
Creation status: Draft / Proposed / merge HOLD
618471110757c74bcf6b7ac3a5783989dd010213173603f8ad3b78866070a2ce756a25102f17c2c9e4fcd3ad277930b02a734302d7a6d0fd9315ec145e36a45aa6d34c6cb547eb32c48f5f81873dab41The ordinary two-parent integration preserves the complete predecessor lineage while materializing the authoritative reviewed tree. Compared with the last restored #2543 head
8e5c1963547dfa88fb596f8a9c160c4c6eb24ffa, it is three commits ahead with zero effective file differences. Compared with canonical #2530, the creation-time effective delta was exactly four reviewed paths:CHANGELOG.mddocs/product-technical-gap-baseline.mdscripts/ci/opencode_review_normalize_output.pytests/test_opencode_review_normalize_output.pyNo predecessor Check or approval transfers. Fresh terminal exact-head Checks, zero unresolved actionable threads, and a qualifying independent
APPROVEDreview remain mandatory. #2543 remains open until this successor transfer is fully accepted; no bypass, auto-merge, Force Push, destructive rebase, source-neutral rerun, or closure is authorized.