Skip to content

fix(review): preserve semantic leaf from retry regressions - #2564

Draft
seonghobae wants to merge 89 commits into
fix/full-suite-parser-locks-20260930from
fix/opencode-review-integrity-successor-20261003
Draft

seonghobae wants to merge 89 commits into
fix/full-suite-parser-locks-20260930from
fix/opencode-review-integrity-successor-20261003

Conversation

@seonghobae

@seonghobae seonghobae commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Current exact authority — 2026-10-07

  • Exact head: 4a66f579b645bd80280fa8a73ac700f9e7cf4a33.
  • Exact tree: 9c507339ec6253dfb60ebad5725aa8403a4fffd2, identical to the independently reviewed local tree.
  • Canonical stacked base: fix/full-suite-parser-locks-20260930@e4fcd3ad277930b02a734302d7a6d0fd9315ec14.
  • RCA: Python's default JSON decoder silently retains the last repeated object member. A model artifact containing a stale first head_sha and a later current head_sha could therefore replace review identity before exact-run validation.
  • RED → GREEN: RED on predecessor 3ecb54b896fbf4c9b7fea1bf8749c28cc558c0cd proves direct duplicate-object admission and CLI identity replacement with exit 0. The minimal GREEN routes both pure-JSON and mixed-prose candidates through the standard decoder's recursive object_pairs_hook, rejects the first repeated name at any depth, and preserves the artifact on failure.
  • Exact blobs: normalizer 1a38c4a2a5af08add6eabd47b8f15c3853d1d063; regressions a826a4e0917e704fca7b7079e12bf1c703ebc7fe; CHANGELOG 172566ecd7756473dbeff64f6171166c3d5d0b5c; Gap baseline bfb056ed10cfbe8c8a384f2f132a0d572d996c06.
  • Local verification: focused normalizer 174/174; target module 863/863 statements and 432/432 branches with zero partials; public-doc 100%; warning-fatal repository suite 5,375 passed, 10 skipped, 40 subtests; compileall and diff checks pass.
  • Independent review: no Critical, Important, or Minor finding. Additional escaped-equivalent-key, nested-array, mixed-prose, Diagnostic-recovery, and nested-promotion probes pass.
  • Hosted exact-head evidence: SAST run 37592701515 failed job 112697755335; Security run 37592701558 failed jobs 112697755933 and 112697756263 while downstream jobs skipped; CodeQL run 37592701548 skipped all jobs. All three failed jobs expose zero steps and their log endpoints return 404 BlobNotFound; no source failure or hosted pass is claimed.
  • Lifecycle: Draft / Proposed / merge HOLD. Fresh successful exact-head hosted Checks and a qualifying independent APPROVED review remain mandatory. No bypass, auto-merge, Force Push, destructive rebase, wake commit, predecessor closure, or source-neutral rerun is authorized.

Prior exact authority — 2026-10-03

  • Exact head: 3ecb54b896fbf4c9b7fea1bf8749c28cc558c0cd.
  • Exact tree: 774d64261ea72c9128c1e212ca714346bc849b52, byte-identical to the independently tested local tree.
  • Canonical stacked base: fix/full-suite-parser-locks-20260930@e4fcd3ad277930b02a734302d7a6d0fd9315ec14.
  • RCA: the line-local scanner recognized backtick fence delimiters but not root tilde fences. The first generalization still missed blockquote/list containers; its regex repair then admitted exponential backtracking and missed continuation indentation. Delimiter-line exact-run JSON could therefore acquire approval authority, while hostile prefixes could stall the gate.
  • Test-first repair chain: root RED 11c9c5ca2dce8d7ef32b078d76d7cd31101557e2 → GREEN 02f2763ff08d05060c66c8d6531df1aa8e49d035; nested RED 0c226a1587b089a1ab267e48ab00ec9b0b69214c → GREEN 3ddd31841b73c6d5ae8555f6c8a838cb2b5f4e55; continuation/ReDoS RED f2aada37f6aa904442105d653d1217b834d8a18f → final GREEN e5ef765fb523596fdcc683876d80bc1bc644e566; documentation child 3ecb54b896fbf4c9b7fea1bf8749c28cc558c0cd.
  • Final boundary: backtick and tilde delimiter lines are non-authoritative under root, blockquote, list-item, and continuation indentation. Prefix admission uses a conservative fail-closed container-marker allowlist, not a full Markdown parser, and evaluates at most one fence candidate per line.
  • Exact blobs: normalizer 1a5fef1e82eaf97f596e28615a5e122615a2b6bd; regression tests c6d3cb4b5689134fcff89fe79596d8362aa73b01; CHANGELOG b81dc4e4025286f895ebf9c851786fa44e43cd0c; Gap baseline 71bffa460973c9be33112631d61f6ab7a7377069.
  • Verification: focused normalizer 171/171; warning-fatal repository suite 5,372 passed, 10 skipped, 40 subtests; Gap-baseline contracts 7 passed plus 4 subtests; complete Strix quick-gate harness PASS; compileall and diff checks pass. A 100,000-marker failing prefix completes in about 0.03 seconds. No new local coverage percentage is claimed.
  • Independent review: three read-only passes found the nested bypass, then the ReDoS/continuation gaps, and finally no remaining approval-evidence bypass or performance regression.
  • Review state: zero unresolved threads and zero qualifying approvals. Earlier COMMENT reviews do not transfer approval to this head.
  • Hosted exact-head evidence: CodeQL run 37123424136 skipped all three jobs before steps; SAST run 37123424140, job 111203866780, failed before steps; Security run 37123424115 failed Detect changed scope and gitleaks before steps while downstream jobs skipped. Every cited job has steps=null and logs_url=null. No hosted parser, security, CodeQL, model, or coverage pass is claimed; blind rerun is not warranted.
  • Lifecycle: Draft / Proposed / merge HOLD. Fresh successful exact-head hosted Checks, hosted coverage, and a qualifying independent APPROVED review remain mandatory. No bypass, auto-merge, Force Push, destructive rebase, wake commit, predecessor closure, or source-neutral rerun is authorized.

Problem

Predecessor #2543 repeatedly received source-changing commits titled as CI retries. Four descendants — ed10aad2, d1ead4ea, 9d7c104b, and 5e36a45a — converged on stale tree d73efe793a59a1ea354e43d62d4da4fa962d1216, twice undoing an exact-tree restoration and removing eleven reviewed owner/leaf paths.

Initial verified successor transfer

This creation-time topology is preserved as lineage evidence; the current authority section above supersedes its head, tree, effective delta, and lifecycle.

Creation status: Draft / Proposed / merge HOLD

The ordinary two-parent integration preserves the complete predecessor lineage while materializing the authoritative reviewed tree. Compared with the last restored #2543 head 8e5c1963547dfa88fb596f8a9c160c4c6eb24ffa, it is three commits ahead with zero effective file differences. Compared with canonical #2530, the creation-time effective delta was exactly four reviewed paths:

  • CHANGELOG.md
  • docs/product-technical-gap-baseline.md
  • scripts/ci/opencode_review_normalize_output.py
  • tests/test_opencode_review_normalize_output.py

No predecessor Check or approval transfers. Fresh terminal exact-head Checks, zero unresolved actionable threads, and a qualifying independent APPROVED review remain mandatory. #2543 remains open until this successor transfer is fully accepted; no bypass, auto-merge, Force Push, destructive rebase, source-neutral rerun, or closure is authorized.

seonghobae and others added 30 commits September 30, 2026 17:39
…canning

Also fixes trivy-fs and pip-audit CI security failures by updating test fixtures and dependency pins.
…canning

Also fixes trivy-fs and pip-audit CI security failures by updating test fixtures and dependency pins. Triggered CI retry for async failure.
…canning

Also fixes trivy-fs and pip-audit CI security failures by updating test fixtures and dependency pins. Cargo update complete.
Preserve the concurrent last-label parser tests, correct their verification-label fixture, and inherit the complete PyJWT 2.15.0, urllib3 2.8.0, and PyO3 0.29.2 owner repair without a leaf copy.
…canning

Also fixes trivy-fs and pip-audit CI security failures by reverting out-of-scope dependency changes and preserving only parser changes.
Preserve the concurrent #2543 lineage while inheriting the complete parser/security/coverage successor. The effective leaf delta is the rfind implementation plus corrected last-label regression tests.
Keep the latest concurrent branch history and the verified #2530-based parser/test tree. No force update or source copy.
Remove generated complexity claims that do not describe the bounded scan contract. Preserve the current #2543 tests and complete #2530 ancestry.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head verification review for e95f0fe05e533156188a1554ae8ffe8967f4377e / tree fef72911f8074c34bd747614be934a4ae43a2976: no additional Critical or Important finding in the integrated five-path delta. Local evidence: normalizer 134/134; repository 5,335 passed, 10 skipped, 40 subtests; target statement/branch coverage 100% (788/390, zero misses/partials); public-doc coverage 100%; filtered and full Strix PASS; static checks GREEN. This is a COMMENT, not an approval. PR remains Draft / Proposed / merge HOLD pending fresh terminal hosted exact-head Checks and a qualifying independent approval.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final exact-head evidence note for a62fe71a7573cf377da535d2dcb72e9f714b263d / tree 54cee0a6bd8a25bf54fbf454a495f7230866f2a8: this child changes only CHANGELOG and the Gap baseline to replace stale pre-integration counts with the observed 134/134, 5,335 passed / 10 skipped / 40 subtests, 100% target statement/branch/public-doc coverage, and complete Strix PASS. The executable blobs are identical to verified repair head e95f0fe0…; final docs diff passes whitespace/conflict checks. This is a COMMENT, not an approval. Draft / Proposed / merge HOLD remains mandatory pending terminal hosted exact-head Checks and an independent approval.

Copy link
Copy Markdown
Contributor Author

Exact-head linear-framing repair ready for hosted admission

Current authority: d2f1f1530a0e37ac6d17c23fceac8a9a861dbbe1 / tree 5c8298bfaa8736a4151f4315d869e934abab537a.

  • Independent review found one Important complexity regression on predecessor a62fe71a…: per-nested-opener prefix-wide rfind() made untrusted transcript parsing approach quadratic time.
  • RED e9a080f59ff6d85101c78da8ac1d4eddcd53c7b7 deterministically observes 129 reverse searches for 64 nested openers.
  • GREEN 5f5c2dc9b3ad8e7476663ce4d3c32ee49a8de4a4 preclassifies exact line-local Diagnostic: opener positions once and uses O(1) membership during nesting; the same probe observes one decoder-internal search.
  • Independent focused re-review of final docs head: Critical 0, Important 0, Minor 0. Reproduced scaling is 16k/32k/64k/128k ≈ 0.0099/0.0197/0.0410/0.0768 seconds.
  • Diagnostic array/object and indented CRLF compatibility frames pass. Same-line pending, false labels, unfinished quotes, invalid outer wrappers, and balanced malformed recovery remain fail-closed; closed quoted prose preserves a later independent control.
  • CHANGELOG and docs/product-technical-gap-baseline.md bind the exact RED/GREEN evidence.

Ready is review admission, not approval or merge readiness. Merge stays HOLD until terminal exact-head hosted Checks and a qualifying independent APPROVED review exist. No bypass, auto-merge, Force Push, destructive rebase, blind rerun, wake commit, or predecessor closure is authorized.

@seonghobae
seonghobae marked this pull request as draft October 3, 2026 10:29

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head COMMENT review for 2974f7a806af50bcc64be627d37182683467b61e / tree 2fd94cfb8b41056dd7c8d3e9dfb37061f8cacd79. RCA→RED→GREEN covers quoted-control false positives, quoted-delimiter false negatives, contraction and quote-adjacency identity, exact mixed backtick runs, Markdown fence compatibility, 10,000-level decoder recursion, and same-line prefix-copy complexity. Independent read-only review required three passes; all reported Critical/Important findings were converted to executable regressions, and the final pass reports none remaining with constant copied width and linear timing. Verification: normalizer 156/156; warning-fatal repository suite 5,357 passed, 10 skipped, 40 subtests; documentation contracts 30 plus 4 subtests; compileall/diff checks pass. Local coverage tools were unavailable, so no new percentage is claimed. Hosted SAST/Security/CodeQL jobs failed before steps (steps=null, logs_url=null). This is a COMMENT, not an approval. Draft / Proposed / merge HOLD remains mandatory pending fresh hosted coverage/check evidence and a qualifying independent APPROVED review.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head COMMENT review for 46229694e20228a1835b57a4f51d72e2f50f574c / tree 2e01ba68ff4d17255c3ffa77c902ec94907abd9f. RED 807fba4b845cba193126c1484b52e803315865a7 proves that controls in opening and closing Markdown fence delimiter lines were promoted as top-level authority. GREEN 705ac4a0a76d8160cc229e2b5e5a0337b7dfb2c9 keeps delimiter-line state through newline; the documentation child records the boundary and lifecycle. Verification: normalizer 158/158; warnings-fatal repository suite 5,359 passed, 10 skipped, 40 subtests; Gap contracts 7 plus 4 subtests; full Strix harness PASS; compileall/diff checks GREEN. Hosted exact-head CodeQL/Security/SAST runs produced no executable steps, and there is no qualifying approval. This is a COMMENT, not an approval. Draft / Proposed / merge HOLD remains mandatory.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final exact-head COMMENT review for 420f631b3b8bc0bb3c8dae4d69134ce97d932e02 / tree c17f316f03ed99f70b5f85e828a01c81f27e5e49. This fast-forward child restores the complete CHANGELOG blob 04a5719bb1c1120831b731abd0d4b1358f631460 and Gap-baseline blob f041fc429c0db254db9fd8fac4d5fe0e3f9a0859 after the first Git Data publication truncated large command output; the final remote tree is byte-identical to the independently tested local tree. RED 807fba4b845cba193126c1484b52e803315865a7 and GREEN 705ac4a0a76d8160cc229e2b5e5a0337b7dfb2c9 remain unchanged. Fresh final-tree verification: warnings-fatal repository suite 5,359 passed, 10 skipped, 40 subtests; complete Strix harness PASS; diff and compile checks exit 0. Hosted CodeQL/SAST/Security exact-head runs remain zero-step/skipped failures, with no qualifying approval. This is a COMMENT, not an approval. Draft / Proposed / merge HOLD remains mandatory.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head verification review for 3ecb54b896fbf4c9b7fea1bf8749c28cc558c0cd / tree 774d64261ea72c9128c1e212ca714346bc849b52.

RCA and repair evidence:

  • Root tilde delimiter controls: RED 11c9c5ca… → GREEN 02f2763f….
  • Blockquote/list delimiter controls: RED 0c226a15… → GREEN 3ddd3184….
  • Continuation indentation plus regex ReDoS/prefix-copy: RED f2aada37… → final GREEN e5ef765f….
  • The final scanner uses a conservative fail-closed marker allowlist, evaluates one fence candidate per line, retains transparent fenced-body controls, and completes a 100,000-marker failing prefix in about 0.03 seconds.

Fresh verification:

  • normalizer: 171/171
  • warning-fatal repository suite: 5,372 passed, 10 skipped, 40 subtests
  • Gap baseline: 7 passed plus 4 subtests
  • complete Strix quick-gate: PASS
  • compileall and diff check: PASS
  • independent final pass: no remaining approval-evidence bypass or performance regression reproduced

Hosted exact-head runs are not passes: CodeQL 37123424136 skipped before steps; SAST 37123424140 and Security 37123424115 failed before steps, with steps=null and logs_url=null. Zero qualifying approvals remain. Keep Draft / Proposed / merge HOLD; no bypass, rerun, wake commit, or merge is justified.

@seonghobae seonghobae left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exact-head COMMENT review for 4a66f579b645bd80280fa8a73ac700f9e7cf4a33 / tree 9c507339ec6253dfb60ebad5725aa8403a4fffd2. RED on predecessor 3ecb54b8… proves default last-wins JSON decoding admitted repeated members and let a later duplicate head_sha replace stale identity before validation. GREEN applies one recursive stdlib object_pairs_hook at both pure-JSON and mixed-prose decoder boundaries and preserves the rejected artifact. Verification: normalizer 174/174; target 863 statements and 432 branches at 100% with zero partials; public-doc 100%; warning-fatal repository suite 5,375 passed, 10 skipped, 40 subtests; compileall/diff checks PASS. Independent review reports no Critical/Important/Minor finding and additionally exercises escaped-equivalent keys, nested arrays, mixed prose, Diagnostic recovery, and nested-promotion rejection. Hosted exact-head SAST 37592701515 and Security 37592701558 failed before steps; CodeQL 37592701548 skipped. Failed jobs have steps=[] and logs return 404 BlobNotFound. This is a COMMENT, not an approval. Keep Draft / Proposed / merge HOLD pending successful hosted Checks and a qualifying independent APPROVED review.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ci-cd CI, GitHub Actions, checks, release, or supply chain priority: high High-priority or P1 work status: blocked Blocked by conflict, dependency, or required prerequisite type: bug Defect or incorrect behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant