Skip to content

Record accepted auto route and scoped Noema publication #2632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seonghobae merged 3 commits into from
Oct 13, 2026
Merged

Record accepted auto route and scoped Noema publication #2632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce207e9
record acceptance of public auto review routing
seonghobae Oct 13, 2026
3e0709c
assert Noema App write scope follows read-only review preparation
seonghobae Oct 13, 2026
fcebff6
enforce Noema read-before-write token ordering
seonghobae Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/adr/2026-10-11-public-personal-auto-authorization.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

## Status

Proposed in ContextualWisdomLab/.github#2607; the maintainer's requested endpoint and model are explicit session instructions.
Accepted on 2026-10-13 after ContextualWisdomLab/.github#2607 merged. The maintainer's requested endpoint and model are explicit session instructions. Runtime App review and approval remain separate acceptance evidence.

## Context and decision drivers

Expand Down
11 changes: 11 additions & 0 deletions tests/test_noema_premerge_production_caller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,17 @@ def test_normal_noema_has_no_unprovisioned_external_admission():
assert 'noema-accepted-tooling.json' not in source


def test_normal_noema_uses_read_only_metadata_then_scoped_app_publication():
"""Ordinary reviews read PR scope before granting a fresh write token."""
source = (ROOT / '.github/workflows/noema-review.yml').read_text()
metadata = source.split(' - name: Refresh read-only Noema GitHub App metadata token after model\n', 1)[1].split(' - name:', 1)[0]
publication = source.split(' - name: Refresh repository-scoped Noema GitHub App token for publication\n', 1)[1].split(' - name:', 1)[0]
assert 'permission-pull-requests: read' in metadata
assert 'permission-pull-requests: write' in publication
assert source.index('Prepare Noema model verdict\n') < source.index('Refresh repository-scoped Noema GitHub App token for publication\n')
assert source.index('Refresh read-only Noema GitHub App metadata token after model\n') < source.index('Refresh repository-scoped Noema GitHub App token for publication\n')


def test_actual_cli_refuses_missing_independent_pins(tmp_path):
"""An unconfigured production caller cannot silently return success."""
result = subprocess.run(
Expand Down
Loading