Repository navigation
test(core): preserve exact international limitation byte bounds - #346
seonghobae wants to merge 1 commit into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthrough국제 릴리스 제한 메타데이터에 UTF-8 바이트 길이 경계 회귀 테스트를 추가했습니다. 정확히 1024바이트인 입력의 보존과 1025바이트 입력의 필드별 오류를 확인합니다. 테스트 전략과 변경 이력도 갱신했습니다. ChangesUTF-8 경계 검증
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The UTF-8 boundary tests add regression protection without changing release behavior. No actionable merge-blocking risk remains after normal checks. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings
🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
1 participant
Summary
Add two deterministic regressions for international UTF-8 release-limitation text. Each independently fixes the public 1024-byte contract, accepts and preserves exact 1024-byte text, and rejects 1025 bytes with the field-specific claim or consequence error. Production validation is already correct and unchanged. This is regression sensitivity, not a production defect or release authorization.
Source and preservation
Protected base
87c4daa1830bac5a5228b6036752ad5633232085; clean exact committed heade6cade752b9f1959bef27ce4e916bb94f19787dc. Three files and 46 insertions:crates/originweave-core/tests/release_limitation_utf8_exact_bounds.rs,docs/TEST_STRATEGY.md, andCHANGELOG.md. Existing four resource-bound tests remain intact. No production, dependency, workflow, credential, provider, policy, release or deployment change.Original dirty46 raw status and regular-file hashes and all 11 baseline worktree registration records were reverified before publication. Missing baseline directories remain unknown, not fabricated clean. One canonical writer; the prior eight published owned worktrees remain clean. Existing producer and reviewer requests were not replayed or cancelled. The complete pre-publication inventory contained 154 open PRs and 20 issues. Related PR195/PR324 lineage was inspected before selecting the missing international-byte boundary regression.
Sensitivity and paired-consumer verification
Isolated protected-base archive: four targeted mutations preserve existing ASCII behavior while incorrectly admitting or rejecting international claim/consequence byte boundaries. All four escape the old four tests and are detected by the new two tests at the intended field assertion. Restored control passes all six tests. Production source in the live checkout was never mutated; mutation targets are separate from acceptance targets.
The complete actual PR324 archive at
4e70d5ed9ce13f7b59012d39646e94ac41519c89plus the unchanged new test passes six focused tests with zero failures/ignored. This is paired-consumer compatibility, not whole PR324 acceptance or protected-main shipment.Independent substantive source review of the actual complete three-file patch SHA256
b007c660e87a924d514b0eefbb1e051fc49712c1f62a5c5b74a7a46f20afe985is PASS with no security or logic findings. Report SHA256b96a0d92a3db8807b1bef0d25e09cfdc63c8c18c285cb7c04ec068275cd27b9e. The reviewer read the real checkout, production boundary, existing tests and complete changed files. Local review is not counted GitHub approval.Clean committed-head verification
All eight commands passed after commit against clean head
e6cade752b9f1959bef27ce4e916bb94f19787dcusing locked/offline dependencies, jobs2, serial gates and isolated targets:CONTRIBUTING cargo check all-targets and compileall scripts/tests also passed on this clean head. Coverage JSON SHA256
d70a49c54c9042082140e7a9d8f23559d82814880639013d1d33dca37700a39c. Candidate and clean committed-head acceptance are separate receipts. Instantiation coverage is not claimed as 100%.Hosted and protected-merge boundary
Normal non-force push and Ready admission do not establish hosted acceptance or merge approval. Fresh exact-head hosted checks, eligible counted approval under current rules, resolved findings and live-base checks remain required before normal protected merge. No merge, protected-main shipment, release, deployment or overall Goal completion is claimed.
Summary by CodeRabbit