Skip to content

test(ci): drop unsupported NIM reasoningEffort knob - #885

Closed
cursor[bot] wants to merge 3 commits into
developfrom
cursor/bc-2ca0f169-ec01-4e67-9e48-4c1bf573b3e0-9f61
Closed

test(ci): drop unsupported NIM reasoningEffort knob#885
cursor[bot] wants to merge 3 commits into
developfrom
cursor/bc-2ca0f169-ec01-4e67-9e48-4c1bf573b3e0-9f61

Conversation

@cursor

@cursor cursor Bot commented Aug 16, 2026

Copy link
Copy Markdown

Closed as proven duplicate of canonical #881

Exact evidence before closure:

No checks/reviews transfer from this duplicate. #881 must regenerate exact-current-head CI/security/SBOM/supply-chain/review evidence, and #879 remains a separate divergent predecessor until its unique delta is adjudicated rather than guessed away.

cursoragent and others added 3 commits August 16, 2026 16:12
ContextualWisdomLab no longer uses GitHub Models. Point opencode.jsonc
at nvidia-nim only, with NVIDIA_API_KEY and the Nemotron Super default.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Pin small_model and leftover GitHub Models ids in the supply-chain
contract, and document that local OpenCode binds NVIDIA_API_KEY while
CI maps the NVIDIA_NIM_API_KEY secret.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
Nemotron Super 49B v1.5 uses chat_template_kwargs, not OpenAI-style
reasoningEffort. Lock the absence, keep {env:NVIDIA_API_KEY}, and
document the local-vs-central OpenCode split.

Co-authored-by: Seongho Bae <seonghobae@users.noreply.github.com>
@seonghobae
seonghobae marked this pull request as ready for review August 16, 2026 16:30
@seonghobae
seonghobae self-requested a review as a code owner August 16, 2026 16:30
@cursor

cursor Bot commented Aug 16, 2026

Copy link
Copy Markdown
Author

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (head acf1f37e)

This is the NIM-contract landing vehicle. Prefer this over #879 (6ca06d3f) and #881 (8f3f1631). Do not merge more than one of those three.

Held on this head:

  • enabled_providers is ["nvidia-nim"]
  • {env:NVIDIA_API_KEY} at https://integrate.api.nvidia.com/v1
  • small_model is nvidia-nim/meta/llama-3.3-70b-instruct
  • Nemotron Super has no reasoningEffort
  • leftover deny-list includes github-models, STRIX_GITHUB_MODELS_TOKEN, COPILOT_GITHUB_TOKEN, openai/gpt-5, openai/o3, openai/o4-mini, and models.github.ai
  • config text also rejects {env:NVIDIA_NIM_API_KEY} so the local binding is not renamed to the org secret
  • review-agent credential names and central scheduler routing stay unchanged
  • doctoring is in docs/doctoring/opencode-nvidia-nim-contract.md with APA 7th NVIDIA citations

No Critical findings. Do not self-approve or merge until exact-head CI and a qualifying independent non-author last-push approval exist.

Do not mix Stem Lab (#884) or lock-in residual (#880) onto this PR.

Open in Web View Automation 

Sent by Cursor Automation: Fix Issues

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review (acf1f37e vs develop@acdbea63)

This PR is closed unmerged. The same head is the current landing on open #881. Do not merge #885.

Scope: 7 files, +162/−50. Local OpenCode stays NVIDIA NIM only. This head drops OpenAI-style reasoningEffort on nvidia/llama-3.3-nemotron-super-49b-v1.5, keeps {env:NVIDIA_API_KEY}https://integrate.api.nvidia.com/v1, rejects {env:NVIDIA_NIM_API_KEY} inside opencode.jsonc, and leaves review-agent credentials in ContextualWisdomLab/.github.

CodeRabbit CLI agent auth timed out in this environment. Findings are from the CodeRabbit reviewer agent plus an exact-head config parse.

CodeRabbit raised 2 issues, both Info. Critical: 0. Warning: 0.

Held on this SHA:

  • enabled_providers is ["nvidia-nim"] only
  • default and small_model stay on nvidia-nim
  • no options.reasoningEffort on Nemotron Super 49B v1.5
  • leftover github-models / STRIX_GITHUB_MODELS_TOKEN / COPILOT_GITHUB_TOKEN / openai/o3 / openai/o4-mini strings are absent
  • scheduler credential test no longer reads local opencode.jsonc

Non-blocking follow-ups belong on #881, not a third NIM PR: dedupe the two contract tests, and lock reasoningEffort against the whole opencode.jsonc text the same way leftover tokens are locked.

Do not restore COPILOT_GITHUB_TOKEN. Do not rename the local binding to {env:NVIDIA_NIM_API_KEY}. Do not mix Stem Lab onto this slice.

Open in Web View Automation 

Sent by Cursor Automation: Fix Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants