feat(workspace): open tonight's first notes on the groove map - #905
feat(workspace): open tonight's first notes on the groove map#905seonghobae wants to merge 7 commits into
Conversation
After a part is selected, Transcribe was a no-op for bass and a coming-soon dead end for everyone else. Name the first notes or range and focus the existing Groove Map so the next rehearsal action is visible. Do not invent a new MIR extractor.
|
Warning Review limit reached
Next review available in: 48 minutes Limit details: You’ve used all 1 included review currently available under your plan. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (11)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
Buyer-visible gap
After a part is selected, Transcribe Bass did nothing for bass and said coming soon for every other role. The groove map already sat underneath with tonight's notes or an empty panel. A bandmate who had just picked a part still could not start on the first notes.
Cites Figma 19-526 Groove Map and
docs/design-system/component-contract.md.Product outcome
Current regression repair
Protected base:
develop@acdbea6344fe1231c39535b575f4de35e4c607c9.Exact current head:
bc3a69b736b5d84197b0abd55d92ce308e29657e.Current-code inspection found and repaired two same-scope behavior gaps on the canonical branch:
roleCuepreviously made the first-notes control actionable even when both transcription and a complete range were absent, while its visible and accessible label still said no notes were ready. The focused cue-only Bass Guitar regression now requires the unavailable control to remainaria-disabled, perform no groove-map focus/scroll, and emit no cue-only first-notes status.A2at absolute onset42; the action must expose that real later note as0:42and render it in the groove map.No dependency/root-lock, workflow, generic filesystem/network/subprocess authority, or security-suppression change belongs to this PR.
Exact-current-head repository gate state
Repository workflows on
bc3a69b...are terminal-success forci,release,build-baseline,sbom,secret-scan-gate,SAST Semgrep, andbandit.security-auditand aggregateSecurity Scanare terminal-failure and therefore non-passing. This PR does not modify dependency manifests/root lockfiles or the security workflows; inherited protected-base dependency remediation remains the canonical #783 lane and must be regenerated after that dependency root integrates. Failed/inherited evidence is not treated as success and is not suppressed here.Fresh inline review inspection has zero unresolved threads and no formal reviews are recorded for this PR. There is therefore no qualifying independent non-author last-push approval.
Security notes
Merge gate
develop.Queued, pending, skipped-required, cancelled, failed, prior-head, protected-base, model-only, author/self, or administrative-bypass evidence is non-passing.