Skip to content

๐ŸŽจ Palette: ๋น„ํ™œ์„ฑํ™” ๋ฒ„ํŠผ์˜ ํˆดํŒ ์ ‘๊ทผ์„ฑ ๊ฐœ์„  - #908

Closed
seonghobae wants to merge 1 commit into
developfrom
palette-accessibility-buttons-8360991608235642463
Closed

๐ŸŽจ Palette: ๋น„ํ™œ์„ฑํ™” ๋ฒ„ํŠผ์˜ ํˆดํŒ ์ ‘๊ทผ์„ฑ ๊ฐœ์„ #908
seonghobae wants to merge 1 commit into
developfrom
palette-accessibility-buttons-8360991608235642463

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

๐Ÿ’ก What: Button ์ปดํฌ๋„ŒํŠธ์˜ HTML disabled ์†์„ฑ์„ aria-disabled๋กœ ๊ต์ฒดํ•˜๊ณ  ํด๋ฆญ ์ด๋ฒคํŠธ๋ฅผ ์ฐจ๋‹จํ•˜๋„๋ก ์ˆ˜์ •ํ–ˆ์œผ๋ฉฐ tooltip (title)์„ ์ถ”๊ฐ€ํ–ˆ์Šต๋‹ˆ๋‹ค. Button ํด๋ž˜์Šค์—์„œ ์‚ฌ์šฉํ•˜์ง€ ์•Š๋Š” disabled๋ฅผ ์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Why: HTML disabled ์†์„ฑ์ด ์Šคํฌ๋ฆฐ ๋ฆฌ๋”์™€ ํฌ์ธํ„ฐ ์ด๋ฒคํŠธ๋ฅผ ์ฐจ๋‹จํ•˜์—ฌ ํˆดํŒ์ด ์ž‘๋™ํ•˜์ง€ ์•Š๋Š” ๋ฌธ์ œ๋ฅผ ํ•ด๊ฒฐํ•˜๊ธฐ ์œ„ํ•จ์ž…๋‹ˆ๋‹ค.
๐Ÿ“ธ Before/After: ํ•ด๋‹น ์—†์Œ (๋™์ž‘ ๋ณ€๊ฒฝ)
โ™ฟ Accessibility: ์‹œ๊ฐ ์žฅ์• ์ธ ๋ฐ ๋งˆ์šฐ์Šค ์‚ฌ์šฉ์ž๊ฐ€ ๋น„ํ™œ์„ฑํ™”๋œ ๋ฒ„ํŠผ์˜ ํˆดํŒ ๋‚ด์šฉ์„ ํ™•์ธํ•  ์ˆ˜ ์žˆ๊ฒŒ ๋˜์–ด ์ ‘๊ทผ์„ฑ์ด ํ–ฅ์ƒ๋˜์—ˆ์Šต๋‹ˆ๋‹ค.


PR created automatically by Jules for task 8360991608235642463 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cursor

cursor Bot commented Aug 17, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 10 minutes

Limit details: Youโ€™ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f24c3fde-c641-48fd-9b16-4bca44dda3e3

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between acdbea6 and d781c62.

๐Ÿ“’ Files selected for processing (5)
  • apps/desktop/src/App.test.tsx
  • apps/desktop/src/components/ui/button.tsx
  • apps/desktop/src/features/score/ScoreView.test.tsx
  • apps/desktop/src/features/score/ScoreView.tsx
  • apps/desktop/src/features/score/ScoreViewer.test.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by the earlier canonical accessibility owner #731 after fresh exact-head comparison.

Exact comparison at this decision point:

The buyer-visible score behavior in #908 is already covered more narrowly and completely by #731: focusable aria-disabled controls, activation prevention at the score action boundary, aria-describedby, localized EN/KO recovery/tooltips, and direct regression assertions. #908's remaining unique change is a global mutation of the shared Button primitive that converts every consumer's native disabled contract into aria-disabled and derives title from aria-label. That broadens semantics across unrelated buttons without a corresponding cross-component requirement or regression inventory, while not adding the localized unavailable-reason contract that #731 already provides for the affected score controls.

No unique accepted product behavior is being discarded: keep #731 as the canonical owner and revalidate it after the dependency/security prerequisites land. Do not transfer #908 checks or evidence to #731.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant