feat(workspace): guide tonight's first chorus on map and player - #939
feat(workspace): guide tonight's first chorus on map and player#939seonghobae wants to merge 1 commit into
Conversation
Name the earliest labeled chorus so the room can open the lift on the map or hear it from the player. Fail closed on verse, pre-chorus, pickup, stop, and handoff labels, and keep Hear behind a real seek callback.
|
Warning Review limit reached
Next review available in: 8 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (17)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![opencode-agent[bot]](https://avatars.githubusercontent.com/in/1549082?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head58c2faf836d5c92f57357459ce1db3e64da764aa. -
Head SHA:
58c2faf836d5c92f57357459ce1db3e64da764aa -
Workflow run: 32220398377
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (16 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (16 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: component-contract.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: component-contract.md"]
R2 --> V2["docs review"]
OpenCode Review Overview
Pull request overviewOpenCode cannot approve yet because required coverage evidence did not pass. Review outcome1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
Coverage evidenceCoverage evidence job did not run or did not publish coverage evidence. Changed-File Evidence Mapflowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (16 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (16 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: component-contract.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: component-contract.md"]
R2 --> V2["docs review"]
|
There was a problem hiding this comment.
Pull request overview
OpenCode cannot approve yet because required coverage evidence did not pass.
Review outcome
1. HIGH .github/workflows/opencode-review.yml:1 - Coverage evidence did not prove required test/docstring evidence
-
Problem: The required coverage-evidence job result was
failure, so OpenCode cannot establish approval sufficiency for this head. -
Root cause: Automated approval is only valid when the same-head coverage-evidence job proves supported repository test suites passed and configured docstring gates passed or were advisory, or reports not applicable because no supported source files or package manifests exist. Missing, failed, skipped, unavailable, or unsupported-tooling test evidence is a blocker.
-
Fix: Install or configure the repository test/docstring evidence tooling when source files or package manifests exist, rerun the current-head coverage-evidence job, and approve only after it reports
successwith required evidence or explicit no-source not-applicable evidence. -
Regression test: Keep the approval branch checking
needs.coverage-evidence.result == successbefore posting APPROVE, and publish REQUEST_CHANGES when coverage-evidence blocker states such as cancelled, skipped, failed, unsupported-tooling, or below-100 evidence are present. -
Result: REQUEST_CHANGES
-
Reason: coverage-evidence result was
failure, so required test/docstring evidence was not proven for current head58c2faf836d5c92f57357459ce1db3e64da764aa. -
Head SHA:
58c2faf836d5c92f57357459ce1db3e64da764aa -
Workflow run: 32224223481
-
Workflow attempt: 1
Coverage evidence
Coverage evidence job did not run or did not publish coverage evidence.
Changed-File Evidence Map
flowchart LR
PR["PR changed files"] --> Evidence["OpenCode bounded evidence"]
Evidence --> S1["Changed file (16 files)"]
S1 --> I1["repository behavior"]
I1 --> R1["Review risk: Changed file (16 files)"]
R1 --> V1["required checks"]
Evidence --> S2["Docs: component-contract.md"]
S2 --> I2["operator or user guidance"]
I2 --> R2["Review risk: Docs: component-contract.md"]
R2 --> V2["docs review"]
1 participant
Product outcome
After analysis, the room can see tonight's first labeled chorus and take one next action: open that lift on the map, or hear it from the player when playback is available.
Cites
docs/design-system/component-contract.md(First Chorus Callout) and the existingchorusform label in@bandscope/shared-types.This is the first structure-label next-action after the coordination labels pickup (#916), stop (#934), and labeled handoff (#937). It is not a parallel MIR product and does not invent a chorus from verse, pre-chorus, pickup, stop, or handoff.
Exact current identity
develop@acdbea6344fe1231c39535b575f4de35e4c607c9.58c2faf836d5c92f57357459ce1db3e64da764aa.feat/workspace-first-chorus-lift.What changed
chorussection whose runtime time window conforms to the shared integer timing contract: non-negative, strictly positive duration, and no endpoint beyondMAX_SECTION_TIME_SECONDS. Do not invent a lift fromverse,pre-chorus,pickup,stop,handoff, graph edges, zero-duration ranges, fractional ranges, or overflowed timestamps.section.idis never DOM-ID authority.후렴rather than the rawchorusenum.Test-first hardening
Dependency routing
nanoid,pdfjs-dist,undici). This feature branch does not suppress or duplicate that authority.Merge gate
Merge only after one unchanged exact head has every applicable repository and central required gate terminal-success, zero valid unresolved findings, exact required owned coverage/docstring evidence, a qualifying independent non-author last-push
APPROVE, and ordinary protected-branch acceptance. Queue/pending/skipped/cancelled/failed/predecessor/protected-base/dismissed/self/author evidence is not success. Never bypass branch protection.Security Notes
is_active === true, one-pass copy interpolation, locale-owned form labels, renderer-position navigation, runtime title containment, and reduced-motion presentation handling.scrollIntoView.