Repository navigation
fix(viewer): remove hard-coded external company branding - #318
seonghobae wants to merge 5 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough뷰어와 데모 HTML 셸의 푸터 문구를 Changes뷰어 브랜딩
Estimated code review effort: 2 (Simple) | ~10분 Mergeability Score: 🔵 Low · up to This PR makes a localized branding correction and is supported by passing automated checks. It is mergeable with explicit owner awareness that the required independent approval must still be obtained before merging. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review @opencode-agent @cwl-noema-review Please independently review exact current head |
🧩 Analysis chain🏁 Script executed: #!/bin/bash
set -euo pipefail
echo '== Checkout and ancestry =='
git rev-parse HEAD
git status --short
git cat-file -e 076574d5145640c881290f5db4aed3ae5fdf8c1f^{commit}
git cat-file -e f3cc09a9838f0f88c81a2ceae22138fab80a2edb^{commit}
git merge-base --is-ancestor f3cc09a9838f0f88c81a2ceae22138fab80a2edb 076574d5145640c881290f5db4aed3ae5fdf8c1f && echo 'base-is-ancestor=yes'
echo
echo '== Changed files and full diff =='
git diff --name-status f3cc09a9838f0f88c81a2ceae22138fab80a2edb 076574d5145640c881290f5db4aed3ae5fdf8c1f
git diff --check f3cc09a9838f0f88c81a2ceae22138fab80a2edb 076574d5145640c881290f5db4aed3ae5fdf8c1f
git diff --find-renames --find-copies --unified=80 f3cc09a9838f0f88c81a2ceae22138fab80a2edb 076574d5145640c881290f5db4aed3ae5fdf8c1f
echo
echo '== License and relevant source/test structure =='
fd -HI '^LICENSE|^NOTICE|^COPYING' . -d 2 -x sh -c 'echo "--- $1"; sed -n "1,120p" "$1"' sh {} \;
fd -HI 'ViewerUiController.*|ViewerUiBrandingContractTest.*' . -x sh -c 'echo "--- $1"; ast-grep outline "$1" --items all || true; cat -n "$1"' sh {}
echo
echo '== Branding references in tracked text files =='
rg -n -i -C 2 --glob '!**/.git/**' 'HYOSUNG|Clearfolio Viewer|Apache-2\.0|Copyright \(c\) 2026' .
echo
echo '== GitHub PR current state =='
gh pr view 318 --repo ContextualWisdomLab/clearfolio --json number,state,isDraft,mergeable,headRefOid,baseRefOid,changedFiles,files,reviews,latestReviews,statusCheckRollup,url
echo
echo '== GitHub inline review threads =='
gh api graphql -F owner='ContextualWisdomLab' -F name='clearfolio' -F number=318 -f query='
query($owner: String!, $name: String!, $number: Int!) {
repository(owner: $owner, name: $name) {
pullRequest(number: $number) {
reviewThreads(first: 100) {
nodes {
isResolved
isOutdated
comments(first: 10) {
nodes { author { login } body commit { oid } path line originalLine }
}
}
}
}
}
}'Length of output: 164869
No actionable findings.
This review does not constitute a merge approval. The PR should remain Draft until the repository review and protection requirements are satisfied.
|
076574d to
2593408
Compare
|
@opencode-agent @cwl-noema-review Please independently review exact current head |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@src/test/java/com/clearfolio/viewer/controller/ViewerUiBrandingContractTest.java`:
- Around line 37-38: Update both branding assertions in
src/test/java/com/clearfolio/viewer/controller/ViewerUiBrandingContractTest.java
at lines 37-38 and 53-54 to verify the exact footer text “<small>Clearfolio
Viewer · Apache-2.0</small>” rather than checking for a generic “Clearfolio
Viewer” presence. Ensure both the root shell and document viewer shell tests
require the complete footer branding.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 9d8f6d3c-bbcf-436b-ac83-3ae95adc5cc5
📒 Files selected for processing (2)
src/main/java/com/clearfolio/viewer/controller/ViewerUiController.javasrc/test/java/com/clearfolio/viewer/controller/ViewerUiBrandingContractTest.java
|
Superseded by current-main reconstruction #447. #447 preserves this PR's two-file buyer-visible branding correction on protected |
Pull request was closed
1 participant
Objective
Advance issue #317 with a bounded production-branding integrity slice. Protected
mainrenderedCopyright (c) 2026 by HYOSUNG. All rights reserved.in the root shell and document viewer even though Clearfolio is independently distributed under Apache-2.0. This slice removes that unrelated hard-coded ownership claim without pretending the larger buyer-demo workspace problem is solved.Fresh exact state — 2026-08-10
046176824929d5185b7431fbe5fb4eb56d1e8237;main:55d7ae8647208e301f282350f076eeddaba61d11after protected merge of fix(security): harden audit pseudonymization and refresh Netty evidence #270;ViewerUiControllerbehavior;31386947737: success;31386947787: success;31386947746: success;31386947790: success;The former divergent branch and predecessor runs are historical. #270 is protected-main behavior. This clean branch first recreated the focused RED regression on that baseline, then applied only the two intended footer replacements.
Test-first evidence
Historical RED
Test-only head
2b7483a428c54baf41afb4d5d024189ecb891317originally addedViewerUiBrandingContractTestwithout changing production. CI31350957100, Maven job93341547450, failed exactly the root/viewer assertions because both surfaces containedHYOSUNG.Clean-baseline GREEN
Current head changes only the two rendered footer claims to
Clearfolio Viewer · Apache-2.0while preserving #270's controller, signed artifact, privacy, and test-evidence changes. The focused contract and full exact-head CI/security/SAST/fuzz gates are GREEN.Scope / product truth
Changed files:
src/main/java/com/clearfolio/viewer/controller/ViewerUiController.javasrc/test/java/com/clearfolio/viewer/controller/ViewerUiBrandingContractTest.javaThis PR does not touch
demo.jsordom-utils.js, which remain owned by #264, and does not duplicate #268 lifecycle, #306 Office conversion, #313 signing-key readiness, or #316 OpenAPI work.Issue #317 still owns removal of browser/service demo authority and the truthful production workspace/session bootstrap. Removing a false company footer is not production-workspace readiness.
Merge gate
Move to Ready for ordinary independent review. Merge only if this unchanged exact head continues to satisfy every live required check, zero valid unresolved findings, the counted write-authorized independent approval required by repository policy, and expected-head-safe protection. Never infer approval from checks/comments/models and do not close issue #317 when this bounded slice integrates.
Summary by CodeRabbit
Clearfolio Viewer · Apache-2.0으로 업데이트했습니다.HYOSUNG브랜드가 표시되지 않고 새 푸터 문구가 정상적으로 표시되는지 검증을 추가했습니다.