🛡️ Sentinel: [CRITICAL] AdminController 인증 및 인가 우회 취약점 해결

.jules/sentinel.md

@@ -32,3 +32,7 @@
 **Vulnerability:** The document hashing routine in `DefaultDocumentConversionService` processed file streams without enforcing any maximum size limit on the bytes read. An attacker could exploit this by uploading a maliciously large stream (or exploiting a compression bomb if unzipping), exhausting system memory, CPU, or disk space (DoS).
 **Learning:** Checking the declared file size (e.g., `file.getSize()`) in initial validation is not always sufficient if the input stream itself can be spoofed or dynamically expanded during reading. The actual bytes read must be verified against bounds continuously.
 **Prevention:** Always enforce a strict, configurable size limit (e.g., `ConversionProperties.maxUploadSizeBytes`) within the `while` loop that reads from untrusted input streams. Track `totalRead` and throw an exception immediately if the limit is exceeded.
+## 2026-02-21 - 관리자 엔드포인트 인증 우회 (Admin Controller Authentication Bypass)
+**Vulnerability:** `AdminController`의 엔드포인트(`/api/v1/admin/convert/jobs`, `/api/v1/admin/convert/jobs/{jobId}` 등)에 어떠한 인증 및 인가 로직도 적용되어 있지 않아, 누구나 변환 작업을 조회, 삭제, 재시도할 수 있었습니다.
+**Learning:** 커스텀 권한 부여 흐름(`TenantAccessService` 주입 등)을 사용하는 애플리케이션에서는 개발자가 명시적으로 서비스 호출을 누락할 경우 기본적으로 엔드포인트가 '모두 허용(open by default)' 상태가 되는 위험이 있습니다.
+**Prevention:** 1) 새로운 관리자 컨트롤러를 작성할 때는 반드시 `TenantAccessService`를 주입받아 각 엔드포인트마다 RBAC 권한(`admin:read`, `admin:write`)을 강제해야 합니다. 2) 장기적으로는 아키텍처가 허용한다면 필터나 애노테이션 기반(예: `@PreAuthorize`)의 중앙집중식 보안 모델로 전환하여 '기본 거부(default-deny)' 정책을 구축하는 것이 좋습니다.

src/main/java/com/clearfolio/viewer/auth/TenantPermissions.java

@@ -55,6 +55,16 @@ public final class TenantPermissions {
      */
     public static final String ANALYTICS_READ = "analytics:read";
 
+    /**
+     * Permission required to read admin endpoints.
+     */
+    public static final String ADMIN_READ = "admin:read";
+
+    /**
+     * Permission required to perform write actions on admin endpoints.
+     */
+    public static final String ADMIN_WRITE = "admin:write";
+
     private TenantPermissions() {
     }
 }

src/main/java/com/clearfolio/viewer/controller/AdminController.java

@@ -4,17 +4,22 @@
 import java.util.List;
 import java.util.UUID;
 
+import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.DeleteMapping;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.PostMapping;
+import org.springframework.web.bind.annotation.RequestHeader;
 import org.springframework.web.bind.annotation.RequestParam;
 import org.springframework.web.bind.annotation.RestController;
 import org.springframework.web.server.ResponseStatusException;
 
 import com.clearfolio.viewer.api.AdminJobListResponse;
+import com.clearfolio.viewer.auth.TenantAccessService;
+import com.clearfolio.viewer.auth.TenantContext;
+import com.clearfolio.viewer.auth.TenantPermissions;
 import com.clearfolio.viewer.model.ConversionJob;
 import com.clearfolio.viewer.service.DocumentConversionService;
 import com.clearfolio.viewer.service.RetryDeadLetterResult;
@@ -25,26 +30,40 @@
 @RestController
 public class AdminController {
 
+    /** Document conversion service. */
     private final DocumentConversionService conversionService;
+    /** Tenant access service. */
+    private final TenantAccessService tenantAccessService;
 
     /**
      * Creates a controller for admin operations.
      *
-     * @param conversionService conversion service
+     * @param conversionSvc conversion service
+     * @param tenantAccessSvc tenant access service
      */
-    public AdminController(DocumentConversionService conversionService) {
-        this.conversionService = conversionService;
+    public AdminController(
+            final DocumentConversionService conversionSvc,
+            final TenantAccessService tenantAccessSvc) {
+        this.conversionService = conversionSvc;
+        this.tenantAccessService = tenantAccessSvc;
     }
 
     /**
      * Retrieves all conversion jobs, optionally filtered by dead-letter status.
      *
+     * @param headers request headers carrying tenant claims
      * @param deadLettered optional filter for dead-lettered jobs
      * @return list of conversion jobs
      */
     @GetMapping("/api/v1/admin/convert/jobs")
-    public AdminJobListResponse getAllJobs(@RequestParam(required = false) Boolean deadLettered) {
-        Iterable<ConversionJob> allJobs = conversionService.getAllJobs();
+    public AdminJobListResponse getAllJobs(
+            @RequestHeader final HttpHeaders headers,
+            @RequestParam(required = false) final Boolean deadLettered) {
+        TenantContext tenantContext = tenantAccessService.require(
+                headers, TenantPermissions.ADMIN_READ);
+
+        Iterable<ConversionJob> allJobs = conversionService.getAllJobs(
+                tenantContext);
 
         if (deadLettered == null) {
             return AdminJobListResponse.from(allJobs);
@@ -62,29 +81,47 @@ public AdminJobListResponse getAllJobs(@RequestParam(required = false) Boolean d
     /**
      * Deletes a conversion job.
      *
+     * @param headers request headers carrying tenant claims
      * @param jobId conversion job identifier
      * @return no content on success
      */
     @DeleteMapping("/api/v1/admin/convert/jobs/{jobId}")
-    public ResponseEntity<Void> deleteJob(@PathVariable UUID jobId) {
-        conversionService.deleteJob(jobId);
+    public ResponseEntity<Void> deleteJob(
+            @RequestHeader final HttpHeaders headers,
+            @PathVariable final UUID jobId) {
+        TenantContext tenantContext = tenantAccessService.require(
+                headers, TenantPermissions.ADMIN_WRITE);
+
+        if (!conversionService.deleteJob(jobId, tenantContext)) {
+            throw new ResponseStatusException(
+                    HttpStatus.NOT_FOUND, "job not found");
+        }
         return ResponseEntity.noContent().build();
     }
 
     /**
      * Retries a dead-lettered conversion job.
      *
+     * @param headers request headers carrying tenant claims
      * @param jobId conversion job identifier
      * @return accepted response on success
      */
     @PostMapping("/api/v1/admin/convert/jobs/{jobId}/retry")
-    public ResponseEntity<Void> retryDeadLettered(@PathVariable UUID jobId) {
-        RetryDeadLetterResult result = conversionService.retryDeadLettered(jobId, "admin");
-        if (result == RetryDeadLetterResult.NOT_FOUND) {
-            throw new ResponseStatusException(HttpStatus.NOT_FOUND, "job not found");
+    public ResponseEntity<Void> retryDeadLettered(
+            @RequestHeader final HttpHeaders headers,
+            @PathVariable final UUID jobId) {
+        TenantContext tenantContext = tenantAccessService.require(
+                headers, TenantPermissions.ADMIN_WRITE);
+
+        RetryDeadLetterResult res = conversionService.retryDeadLettered(
+                jobId, "admin", tenantContext);
+        if (res == RetryDeadLetterResult.NOT_FOUND) {
+            throw new ResponseStatusException(
+                    HttpStatus.NOT_FOUND, "job not found");
         }
-        if (result == RetryDeadLetterResult.NOT_ELIGIBLE) {
-            throw new ResponseStatusException(HttpStatus.CONFLICT, "job is not eligible for retry");
+        if (res == RetryDeadLetterResult.NOT_ELIGIBLE) {
+            throw new ResponseStatusException(
+                    HttpStatus.CONFLICT, "job is not eligible for retry");
         }
         return ResponseEntity.accepted().build();
     }

src/main/java/com/clearfolio/viewer/service/DocumentConversionService.java

@@ -60,6 +60,32 @@ default UUID submit(MultipartFile file, PolicyOverrideRequest overrideRequest, T
      */
     RetryDeadLetterResult retryDeadLettered(UUID jobId, String operatorId);
 
+    /**
+     * Retries a dead-lettered conversion job owned by the supplied tenant.
+     *
+     * @param jobId conversion job identifier
+     * @param operatorId operator identifier that triggered the retry
+     * @param tenantContext tenant and subject claims for the retry request
+     * @return retry outcome, or {@link RetryDeadLetterResult#NOT_FOUND} when
+     *         the job is missing or belongs to another tenant
+     */
+    default RetryDeadLetterResult retryDeadLettered(
+            UUID jobId,
+            String operatorId,
+            TenantContext tenantContext) {
+        if (tenantContext == null) {
+            return RetryDeadLetterResult.NOT_FOUND;
+        }
+        Optional<ConversionJob> job = getJob(jobId);
+        if (job.isEmpty()) {
+            return RetryDeadLetterResult.NOT_FOUND;
+        }
+        if (!job.get().belongsToTenant(tenantContext.tenantId())) {
+            return RetryDeadLetterResult.NOT_FOUND;
+        }
+        return retryDeadLettered(jobId, operatorId);
+    }
+
     /**
      * Deletes a conversion job owned by the supplied tenant context.
      *
@@ -95,4 +121,23 @@ default boolean deleteJob(UUID jobId, TenantContext tenantContext) {
      * @return an iterable of all conversion jobs
      */
     Iterable<ConversionJob> getAllJobs();
+
+    /**
+     * Returns only conversion jobs owned by the supplied tenant.
+     *
+     * @param tenantContext tenant and subject claims for the list request
+     * @return an iterable containing only jobs owned by that tenant
+     */
+    default Iterable<ConversionJob> getAllJobs(TenantContext tenantContext) {
+        if (tenantContext == null) {
+            return java.util.List.of();
+        }
+        java.util.List<ConversionJob> ownedJobs = new java.util.ArrayList<>();
+        for (ConversionJob job : getAllJobs()) {
+            if (job.belongsToTenant(tenantContext.tenantId())) {
+                ownedJobs.add(job);
+            }
+        }
+        return ownedJobs;
+    }
 }