🛡️ Sentinel: [CRITICAL] Fix AdminController Missing Authorization and Tenant Isolation

.jules/sentinel.md

@@ -32,3 +32,7 @@
 **Vulnerability:** The document hashing routine in `DefaultDocumentConversionService` processed file streams without enforcing any maximum size limit on the bytes read. An attacker could exploit this by uploading a maliciously large stream (or exploiting a compression bomb if unzipping), exhausting system memory, CPU, or disk space (DoS).
 **Learning:** Checking the declared file size (e.g., `file.getSize()`) in initial validation is not always sufficient if the input stream itself can be spoofed or dynamically expanded during reading. The actual bytes read must be verified against bounds continuously.
 **Prevention:** Always enforce a strict, configurable size limit (e.g., `ConversionProperties.maxUploadSizeBytes`) within the `while` loop that reads from untrusted input streams. Track `totalRead` and throw an exception immediately if the limit is exceeded.
+## 2026-08-19 - Add Missing Authorization and Tenant Isolation to Admin Endpoints
+**Vulnerability:** The `AdminController` endpoints (`/api/v1/admin/convert/jobs`, `deleteJob`, `retryDeadLettered`) did not verify caller permissions via `TenantAccessService`, allowing unauthenticated actors to access and manipulate all conversion jobs globally. Furthermore, jobs were not scoped to the caller's tenant, exposing cross-tenant metadata (data leak).
+**Learning:** Even internal or admin-specific controllers must apply the same authentication, authorization, and tenant isolation layers as user-facing endpoints to adhere strictly to the principle of least privilege and prevent horizontal/vertical privilege escalation.
+**Prevention:** Always verify endpoint permissions explicitly (e.g., using `TenantAccessService.require(headers, ...)`) and strictly enforce tenant scope (e.g., `job.belongsToTenant(tenantContext.tenantId())` or `requireSameTenant`) for every protected resource, including administrative actions.

src/main/java/com/clearfolio/viewer/controller/AdminController.java

@@ -1,20 +1,30 @@
 package com.clearfolio.viewer.controller;
 
+import java.nio.charset.StandardCharsets;
+import java.security.MessageDigest;
+import java.security.NoSuchAlgorithmException;
 import java.util.ArrayList;
+import java.util.HexFormat;
 import java.util.List;
+import java.util.Optional;
 import java.util.UUID;
 
+import org.springframework.http.HttpHeaders;
 import org.springframework.http.HttpStatus;
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.DeleteMapping;
 import org.springframework.web.bind.annotation.GetMapping;
 import org.springframework.web.bind.annotation.PathVariable;
 import org.springframework.web.bind.annotation.PostMapping;
+import org.springframework.web.bind.annotation.RequestHeader;
 import org.springframework.web.bind.annotation.RequestParam;
 import org.springframework.web.bind.annotation.RestController;
 import org.springframework.web.server.ResponseStatusException;
 
 import com.clearfolio.viewer.api.AdminJobListResponse;
+import com.clearfolio.viewer.auth.TenantAccessService;
+import com.clearfolio.viewer.auth.TenantContext;
+import com.clearfolio.viewer.auth.TenantPermissions;
 import com.clearfolio.viewer.model.ConversionJob;
 import com.clearfolio.viewer.service.DocumentConversionService;
 import com.clearfolio.viewer.service.RetryDeadLetterResult;
@@ -25,36 +35,53 @@
 @RestController
 public class AdminController {
 
+    /** Hex formatter for pseudonymous operator identifiers. */
+    private static final HexFormat HEX_FORMAT = HexFormat.of();
+
+    /** Conversion service. */
     private final DocumentConversionService conversionService;
 
+    /** Tenant access service. */
+    private final TenantAccessService tenantAccessService;
+
     /**
      * Creates a controller for admin operations.
      *
-     * @param conversionService conversion service
+     * @param conversionServiceArg conversion service
+     * @param tenantAccessServiceArg tenant and permission guard
      */
-    public AdminController(DocumentConversionService conversionService) {
-        this.conversionService = conversionService;
+    public AdminController(
+            final DocumentConversionService conversionServiceArg,
+            final TenantAccessService tenantAccessServiceArg) {
+        this.conversionService = conversionServiceArg;
+        this.tenantAccessService = tenantAccessServiceArg;
     }
 
     /**
      * Retrieves all conversion jobs, optionally filtered by dead-letter status.
      *
      * @param deadLettered optional filter for dead-lettered jobs
+     * @param headers request headers
      * @return list of conversion jobs
      */
     @GetMapping("/api/v1/admin/convert/jobs")
-    public AdminJobListResponse getAllJobs(@RequestParam(required = false) Boolean deadLettered) {
-        Iterable<ConversionJob> allJobs = conversionService.getAllJobs();
+    public AdminJobListResponse getAllJobs(
+            @RequestParam(required = false) final Boolean deadLettered,
+            @RequestHeader final HttpHeaders headers) {
+        TenantContext tenantContext = tenantAccessService.require(
+                headers, TenantPermissions.JOB_READ);
 
-        if (deadLettered == null) {
-            return AdminJobListResponse.from(allJobs);
-        }
+        Iterable<ConversionJob> allJobs = conversionService.getAllJobs();
 
         List<ConversionJob> filtered = new ArrayList<>();
         for (ConversionJob job : allJobs) {
-            if (job.isDeadLettered() == deadLettered) {
-                filtered.add(job);
+            if (!job.belongsToTenant(tenantContext.tenantId())) {
+                continue;
+            }
+            if (deadLettered != null && job.isDeadLettered() != deadLettered) {
+                continue;
             }
+            filtered.add(job);
         }
         return AdminJobListResponse.from(filtered);
     }
@@ -63,10 +90,23 @@ public AdminJobListResponse getAllJobs(@RequestParam(required = false) Boolean d
      * Deletes a conversion job.
      *
      * @param jobId conversion job identifier
+     * @param headers request headers
      * @return no content on success
      */
     @DeleteMapping("/api/v1/admin/convert/jobs/{jobId}")
-    public ResponseEntity<Void> deleteJob(@PathVariable UUID jobId) {
+    public ResponseEntity<Void> deleteJob(
+            @PathVariable final UUID jobId,
+            @RequestHeader final HttpHeaders headers) {
+        TenantContext tenantContext = tenantAccessService.require(
+                headers, TenantPermissions.JOB_DELETE);
+
+        Optional<ConversionJob> job = conversionService.getJob(jobId);
+        if (job.isEmpty()) {
+            throw new ResponseStatusException(
+                    HttpStatus.NOT_FOUND, "job not found");
+        }
+        tenantAccessService.requireSameTenant(tenantContext, job.get());
+
         conversionService.deleteJob(jobId);
         return ResponseEntity.noContent().build();
     }
@@ -75,16 +115,42 @@ public ResponseEntity<Void> deleteJob(@PathVariable UUID jobId) {
      * Retries a dead-lettered conversion job.
      *
      * @param jobId conversion job identifier
+     * @param headers request headers
      * @return accepted response on success
      */
     @PostMapping("/api/v1/admin/convert/jobs/{jobId}/retry")
-    public ResponseEntity<Void> retryDeadLettered(@PathVariable UUID jobId) {
-        RetryDeadLetterResult result = conversionService.retryDeadLettered(jobId, "admin");
+    public ResponseEntity<Void> retryDeadLettered(
+            @PathVariable final UUID jobId,
+            @RequestHeader final HttpHeaders headers) {
+        TenantContext tenantContext = tenantAccessService.require(
+                headers, TenantPermissions.JOB_RETRY);
+
+        Optional<ConversionJob> job = conversionService.getJob(jobId);
+        if (job.isEmpty()) {
+            throw new ResponseStatusException(
+                    HttpStatus.NOT_FOUND, "job not found");
+        }
+        tenantAccessService.requireSameTenant(tenantContext, job.get());
+
+        String pseudonymizedOperator;
+        try {
+            MessageDigest digest = MessageDigest.getInstance("SHA-256");
+            byte[] hash = digest.digest(
+                    tenantContext.subjectId().getBytes(StandardCharsets.UTF_8));
+            pseudonymizedOperator = HEX_FORMAT.formatHex(hash);
+        } catch (NoSuchAlgorithmException ex) {
+            throw new IllegalStateException("SHA-256 not available", ex);
+        }
+
+        RetryDeadLetterResult result = conversionService.retryDeadLettered(
+                jobId, pseudonymizedOperator);
         if (result == RetryDeadLetterResult.NOT_FOUND) {
-            throw new ResponseStatusException(HttpStatus.NOT_FOUND, "job not found");
+            throw new ResponseStatusException(
+                    HttpStatus.NOT_FOUND, "job not found");
         }
         if (result == RetryDeadLetterResult.NOT_ELIGIBLE) {
-            throw new ResponseStatusException(HttpStatus.CONFLICT, "job is not eligible for retry");
+            throw new ResponseStatusException(
+                    HttpStatus.CONFLICT, "job is not eligible");
         }
         return ResponseEntity.accepted().build();
     }