Skip to content

๐Ÿ›ก๏ธ Sentinel: [security improvement] ๋Ÿฐํƒ€์ž„ ์‹œํฌ๋ฆฟ ์„ค์ • ๋ฐฉ์‹ ์•ˆ์ „ํ™” (configtree ์ ์šฉ) - #483

Closed
seonghobae wants to merge 1 commit into
mainfrom
feat/migrate-secrets-to-configtree-7758274103332140806
Closed

seonghobae wants to merge 1 commit into
mainfrom
feat/migrate-secrets-to-configtree-7758274103332140806

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

๐Ÿšจ Severity: High
๐Ÿ’ก Vulnerability: ๋Ÿฐํƒ€์ž„ ์‹œํฌ๋ฆฟ(artifact token secret ๋ฐ tenant claims HMAC secret)์„ ํ™˜๊ฒฝ ๋ณ€์ˆ˜(application-buyer-demo.yml ๋‚ด @Value ๊ธฐ๋ณธ๊ฐ’ ์„ค์ •)๋กœ ์ฃผ์ž…ํ•˜๋Š” ๋ฐฉ์‹์€ ์ปจํ…Œ์ด๋„ˆ๋‚˜ ํ”„๋กœ์„ธ์Šค ํ™˜๊ฒฝ์— ๋ฏผ๊ฐํ•œ ์ •๋ณด๊ฐ€ ์œ ์ถœ๋  ์œ„ํ—˜์ด ์กด์žฌํ–ˆ์Šต๋‹ˆ๋‹ค.
๐ŸŽฏ Impact: ๊ณต๊ฒฉ์ž๊ฐ€ ํ”„๋กœ์„ธ์Šค ํ™˜๊ฒฝ ๋ณ€์ˆ˜๋ฅผ ํƒˆ์ทจํ•  ๊ฒฝ์šฐ ํ† ํฐ ์ƒ์„ฑ์ด๋‚˜ ์„œ๋ช… ๋กœ์ง์„ ์šฐํšŒํ•  ์ˆ˜ ์žˆ์–ด ์ „์ฒด ๊ถŒํ•œ ์šฐํšŒ ๋ฐ ๋ฌธ์„œ ์œ ์ถœ์˜ ์‹ฌ๊ฐํ•œ ๊ฒฐ๊ณผ๋ฅผ ์ดˆ๋ž˜ํ•  ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.
๐Ÿ”ง Fix:

  • application-buyer-demo.yml์—์„œ ํ•ด๋‹น ์‹œํฌ๋ฆฟ ์„ค์ •์„ ์ œ๊ฑฐํ•˜์—ฌ Spring Boot configtree์—์„œ๋งŒ ๊ฐ’์„ ๊ฐ€์ ธ์˜ค๋„๋ก ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค.
  • @Value ์• ๋„ˆํ…Œ์ด์…˜์—์„œ : ํด๋ฐฑ(fallback)์„ ์ œ๊ฑฐํ•˜์—ฌ ๋ˆ„๋ฝ๋œ ๊ฒฝ์šฐ ์‹œ์ž‘ ์‹œ์ ์— ์ฆ‰์‹œ ์‹คํŒจํ•˜๋„๋ก ๊ฐ•์ œ(Fail-fast)ํ–ˆ์Šต๋‹ˆ๋‹ค.
  • ๊ด€๋ จ ํ…Œ์ŠคํŠธ(ProductionAuthReadinessConfigTest.java)๋ฅผ ์ˆ˜์ •ํ•˜์—ฌ ๊ฐ’์ด ๋ˆ„๋ฝ๋˜์—ˆ์„ ๋•Œ ์ปจํ…์ŠคํŠธ ๋กœ๋“œ๊ฐ€ ์‹คํŒจํ•จ์„ ์˜ฌ๋ฐ”๋ฅด๊ฒŒ ๊ฒ€์ฆํ•˜๋„๋ก ํ•˜์˜€์Šต๋‹ˆ๋‹ค.
  • CHANGELOG.md ๋ฐ .jules/sentinel.md์— ํ•œ๊ตญ์–ด๋กœ ๋ณ€๊ฒฝ ์‚ฌํ•ญ๊ณผ ๋ฐฐ์šด ์ ์„ ๊ธฐ๋กํ–ˆ์Šต๋‹ˆ๋‹ค.
    โœ… Verification: mvn clean verify๋ฅผ ์„ฑ๊ณต์ ์œผ๋กœ ํ†ต๊ณผํ–ˆ์œผ๋ฉฐ ์ถ”๊ฐ€์ ์ธ ์œ ๋‹› ํ…Œ์ŠคํŠธ๋„ ์˜ค๋ฅ˜ ์—†์ด ์ˆ˜ํ–‰๋˜์—ˆ์Šต๋‹ˆ๋‹ค.

PR created automatically by Jules for task 7758274103332140806 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

๐Ÿ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a ๐Ÿ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

Limit details: Youโ€™ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
โš™๏ธ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2ea5a5ed-e43e-4b31-a917-27a6595eed20

๐Ÿ“ฅ Commits

Reviewing files that changed from the base of the PR and between 06633a2 and 528b0b2.

๐Ÿ“’ Files selected for processing (7)
  • .jules/sentinel.md
  • CHANGELOG.md
  • src/main/java/com/clearfolio/viewer/artifact/ArtifactLinkService.java
  • src/main/java/com/clearfolio/viewer/auth/TenantAccessService.java
  • src/main/java/com/clearfolio/viewer/config/ProductionAuthReadinessConfig.java
  • src/main/resources/application-buyer-demo.yml
  • src/test/java/com/clearfolio/viewer/config/ProductionAuthReadinessConfigTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

โค๏ธ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

Closing as superseded by #482. The unique useful intent hereโ€”preventing the buyer-demo profile from restoring runtime signing-secret environment mappingsโ€”is now covered by #482's focused executable policy test. The additional @Value placeholder changes in this branch broaden the behavior into mandatory property resolution for every composition, mixing a minimal configuration repair with the separate production credential-registry migration. #482 remains the canonical bounded landing path; #319/#344/#354/#433 retain runtime credential authority.

@seonghobae seonghobae closed this Aug 20, 2026
@google-labs-jules

Copy link
Copy Markdown

Closing as superseded by #482. The unique useful intent hereโ€”preventing the buyer-demo profile from restoring runtime signing-secret environment mappingsโ€”is now covered by #482's focused executable policy test. The additional @Value placeholder changes in this branch broaden the behavior into mandatory property resolution for every composition, mixing a minimal configuration repair with the separate production credential-registry migration. #482 remains the canonical bounded landing path; #319/#344/#354/#433 retain runtime credential authority.

Understood. Acknowledging that this work is now superseded by #482 and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant