Repository navigation
feat(design): establish executable Storybook viewer authority - #489
seonghobae wants to merge 31 commits into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughStorybook 검증 구성을 추가했다. 디자인 토큰, Storybook 설정, 문서 뷰어 상태 스토리, Vitest 브라우저 테스트, PR 워크플로와 계약 검증 스크립트를 연결했다. ChangesStorybook 디자인 시스템
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: 🟡 Moderate · up to This PR adds a development-only Storybook viewer-state authority and validation workflow without changing production document access. The current head has successful automated checks, but merging remains blocked because the protected branch lacks a qualifying independent human approval, and previously identified contract-test execution and traceability-documentation issues still require owner follow-up. Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant npm
participant unittest
participant Chromium
participant Storybook
GitHubActions->>npm: lockfile 기반 npm ci 실행
GitHubActions->>unittest: 디자인 시스템 계약 테스트 실행
GitHubActions->>Chromium: Chromium 설치
GitHubActions->>Storybook: Storybook 빌드 및 --run 테스트 실행
Storybook-->>GitHubActions: 브라우저 테스트 결과 반환
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 14 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
The agent generated fixes only for
Lines 27–51 with:
node-version: "24"
- - name: Resolve exact direct development dependencies
- run: npm install --package-lock-only --ignore-scripts --no-audit --no-fund
-
- - name: Emit reviewable lock bootstrap
- shell: bash
- run: |
- printf '%s\n' LOCKFILE_B64_BEGIN
- base64 -w0 package-lock.json
- printf '\n%s\n' LOCKFILE_B64_END
-
- - name: Upload generated lock for checked-in review
- uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
- with:
- name: storybook-package-lock-${{ github.event.pull_request.head.sha }}
- path: package-lock.json
- if-no-files-found: error
- retention-days: 1
-
- - name: Install development dependencies from generated lock
+ - name: Install development dependencies from committed lock
run: npm ci --ignore-scripts --no-audit --no-fund
- name: Run executable design-system contract tests |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
opencode-agent
Bot
added
area: auth
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
2026-08-27 fresh Figma ↔ Storybook parity repair on unchanged exact head
Merge evidence remains fail-closed. Repository CI, Security Scan, SAST Semgrep, and Storybook Design System are terminal-success on this head, and all returned inline threads are resolved/outdated. However, the required central Live organization ruleset |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Scheduled review-feedback autofix for this PR head.
|
|
Current lifecycle authority를 다시 맞춥니다. PR body는 아직 Fresh review inventory에도 qualifying GREEN acceptance: current |
seonghobae
added
the
enhancement
ChatGPT Codex Connector
|
Scheduled review-feedback autofix for this PR head.
|
|
Scheduled review-feedback autofix for this PR head.
|
|
Design assurance exact-head acceptance — This head keeps CI
Acceptance before Ready/merge:
Because this requires the canonical runtime/viewer boundary rather than a cosmetic story edit, I am preserving the current delta and keeping the PR Draft. |
|
Scheduled review-feedback autofix for this PR head.
|
|
Scheduled review-feedback autofix for this PR head.
|
|
Scheduled review-feedback autofix for this PR head.
|
|
Scheduled review-feedback autofix for this PR head.
|
|
Scheduled review-feedback autofix for this PR head.
|
|
Scheduled review-feedback autofix for this PR head.
|
|
Scheduled review-feedback autofix for this PR head.
|
|
Scheduled review-feedback autofix for this PR head.
|
|
Scheduled review-feedback autofix for this PR head.
|
Objective
Advance #476 with one bounded, development-only Figma–Storybook vertical slice for the existing WebFlux/static viewer. Production
viewer.cssremains runtime authority; this PR does not add customer data, runtime network authority, or a second production frontend framework.Test-first sequence
Original RED checkpoint:
f769dd11bd32f0ab19ad86c5c064cda838a4b472added only the Buyer-readiness contract while the required Storybook/token/config files were absent.DTCG review-repair RED
4937133b00f2657640994fbec62cde953efc5b67proved sRGB components just outside[0, 1]were incorrectly accepted after rounding. GREENbfccb02cf8d0b0a744911ac8947ad432bf176c8dvalidates component range before channel conversion while retaining the existing channel-range assertion.Accessibility review-repair RED
4dead75656dc8f1f2a985a10e04cbf81123d97c3added a contract requiring a named preview container to use a semantic, nameable role; the exact-headStorybook Design Systemworkflow failed as expected. GREEN source commitaccbe898f22d2ace9ea4cc02a5aa6c247c64be59changes the named preview wrapper from an implicitgenericdivtorole="region"while preservingaria-labelledby="preview-title". WAI-ARIA 1.2 definesgenericas name-prohibited. Documentation commitbbbe0979107b5ac1942b6d0f37de4579655ac09erecords the standards rationale and Figma traceability.Current exact implementation head:
bbbe0979107b5ac1942b6d0f37de4579655ac09e.The implementation adds:
a11y.test = 'error'with WCAG A/AA through WCAG 2.2 AA and axe best-practice tags;package-lock.jsonandnpm ci --ignore-scripts --no-audit --no-fund;AGENTS.mdcontract that explicitly registers Storybook Design System as a mandatory exact-head gate;The UI copy is action-oriented: loading explains that no action is required yet; every failure explains the next buyer action.
Fresh design evidence
The live Clearfolio Figma file
UPIMvnjyP1sTXhIy1wqD02was re-read and synchronized on 2026-08-27 against unchanged exact headbbbe0979107b5ac1942b6d0f37de4579655ac09e. Page0:1, board2:2still exposes desktop loading/ready/failed, mobile loading, tablet two-pane, design-audit notes, local token authority, andStorybook buyer-state parityframe10:2for document-not-found, invalid-document, and network-error states.The desktop loading/ready/failed screens and the 390px mobile loading screen now use the same buyer-state copy and next-action vocabulary as
design/storybook/viewer-states.stories.js: busy loading keepsTry preview againandDownload originalvisibly disabled while leavingBack to documentsavailable; ready exposesOpen document,Download original, andBack to documents; failed exposesTry preview again,Download original, andBack to documentsand no longer presents a loading skeleton. The mobile action row wraps rather than clipping, and the preview guidance was explicitly reflowed and visually re-verified after synchronization.The palette remains aligned with both
design/tokens/clearfolio.tokens.jsonand productionviewer.css: brand blue#034ea2, ink#102032, muted#5a6777, background#f6f7f9, panel#ffffff, line#d7dde6, danger#b42318, and focus#ff595a.Code Connect component inventory was also rechecked on 2026-08-27 and remains unavailable because the current Figma account lacks the required Dev or Full seat on an Organization or Enterprise plan. This PR records that limitation instead of fabricating mappings; #476 explicitly permits that fail-closed path.
Current evidence status
On exact head
bbbe0979107b5ac1942b6d0f37de4579655ac09e:32681615488: terminal success;32681615532: terminal success;32681615480: terminal success;32681615524: terminal success;APPROVEDreview.The aggregate commit status is not treated as all-passing: CodeRabbit still reports
pending/Review queuedon this exact head, while Devin is terminal-success. The active organization ruleset currently requires one qualifying approving review, stale-review dismissal on push, review-thread resolution, and the central required-workflow set; GitHub therefore continues to report the PR asmergeable_state=blocked.The prior Devin
aria-labelledbyconcern is treated as a valid standards defect despite the predecessor axe run being green: WAI-ARIA 1.2 makes the generic role name-prohibited, so the source supplies a semantic region role and an executable regression.A normal review request for team
independent-reviewerspreviously returned HTTP 422 because that team is not a collaborator ofContextualWisdomLab/clearfolio; #321 owns that provisioning gap. No author review, advisory bot review, stale review, synthetic evidence, or OrganizationAdmin bypass substitutes for the qualifying independent human approval.Scope boundary
#334 and other viewer lifecycle/accessibility branches remain untouched. Before every further write, recheck protected base, this exact branch head, overlapping PRs, review threads, active-writer evidence, and live protection/ruleset behavior. This PR must not merge until all then-live required gates remain terminal-success and a qualifying independent human approval exists through the normal protected path.
Refs #476, #321
Summary by CodeRabbit
새 기능
버그 수정
문서
테스트