Repository navigation
⚡ Bolt: 원시 타입 박싱 방지 및 StringBuilder를 활용한 Ledger 직렬화 최적화 - #687
seonghobae wants to merge 1 commit into
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 35 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
💡 What:
String.join()과String.valueOf()를 사용하여 탭 구분 문자열을 생성하던 Ledger 직렬화 로직(ArtifactLinkLedger,KpiSnapshotLedger)을 미리 크기가 지정된StringBuilder와 메서드 체이닝.append()로 교체했습니다.🎯 Why:
String.join()은 내부적으로 varargs 배열을 생성하며,String.valueOf()는 원시 타입을 박싱하는 불필요한 중간 객체를 생성합니다. 특히 많은 필드를 가진 Ledger 직렬화처럼 빈번하게 호출되는 경로에서는 이는 GC(가비지 컬렉션) 오버헤드를 유발합니다.📊 Impact: 가변 길이 문자열 배열(varargs) 생성과 원시 타입 박싱(String.valueOf)을 방지하여 메모리 할당(Allocation)을 줄이고 런타임 성능을 향상시킵니다.
🔬 Measurement: Ledger 직렬화 메서드를 호출하는 테스트(
mvn -B --no-transfer-progress verify)가 100% JaCoCo 커버리지와 함께 정상 통과함을 확인했습니다.PR created automatically by Jules for task 15923865908379895939 started by @seonghobae