fix(telemetry): export bounded request cohort identity - #1313
seonghobae wants to merge 1 commit into
Conversation
|
Warning Review limit reachedNext included review available in 51 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hosted Strix RCA for run Central fix: ContextualWisdomLab/.github#2486 recognizes only those exact known notices, preserving unknown/provider warnings as failures. This does not retroactively turn this run into a passing protected check. A new current-head hosted verdict is still required after the central fix lands. |
|
Scheduled review-feedback autofix for this PR head.
|
|
Exact-head admission correction — Ready is review admission only. Fresh audit against base
This PR is moved to Draft/Proposed until the causal owner repair is present on a successor exact head and re-audited. Queued/pending work is neither an additional blocker nor passing evidence. No Close, force push, destructive rebase, manual rerun, synthetic status/approval, merge, auto-merge, or bypass was performed. |
|
Scheduled review-feedback autofix for this PR head.
|
Scope
Issue #1110 needs comparable request cohorts before any observed-workload latency claim. The retained admin export had a validated decision duration and policy hash but omitted its known endpoint path and initial selection kind. This change exports only allowlisted values and keeps unrecognized stored strings null.
The selection kind is a hook identity; it does not yet distinguish the caller's route/conduct choice. The export remains local, incomplete, and unreconciled against ingress. This PR does not claim a p95 improvement, customer accuracy, or a released metric.
Evidence
KeyError: 'endpoint_path'before the change..venv.uv run --no-sync python -m pytest -q -W error tests/test_paginated_decision_provenance.py tests/test_request_outcome_export.py: 63 passed, exit 0 atff1242cc.git diff --check: clean.Follow-up boundary
An observed pilot must still reconcile all ingress, capture the caller's validated route/conduct choice, declare the workload and observation window, independently judge delivered answers, and calculate uncertainty before the #1110 or customer KPI acceptance claim. No routing, credential, security gate, or timeout behavior changes here.
Hosted review and queue evidence — 2026-09-28 05:18 UTC
At exact head
ff1242cc4db1cd64ccb8d4603011bd401179ac67, the Strix run 36373616120 completed its scanner process with exit code 0; itsrun.jsonrecordsstatus=completed,scan_completed=true,success=true, and SARIF has 0 results. The trusted central gate still returned failure because the report log containedstrix.tools.web_search.tool: web_search invoked without PERPLEXITY_API_KEY configured. That optional-tool warning is not evidence thatorchestrator/freeexhausted. The owned narrow sanitizer repair already exists in ContextualWisdomLab/.github#2117; it is still Draft and has not been adopted by a terminal current-head run. Scanner completion and zero findings do not override this gate failure.The Security “Tests and package quality” job 108774861880 remains
queuedwithrunner_id=0; 11 required jobs on this head are queued. The reusable centralscan-pr-queuejob 108774863086 is already labeledself-hosted, linux, x64but has no assigned runner. No current-head hosted quality or independent review verdict follows from this queue observation. Preserve this head until a confirmed fix or review action calls for a push.2026-09-28 Strix and queue RCA
Strix run 36373616120 ended with scanner rc=0,
run.jsoncompleted/success, and SARIF 2.1.0 with zero results. Its exact optional web-search warning plus repeated PTY session-count threshold notices caused the central gate to label the completed scanSTRIX_PROVIDER_UNAVAILABLE. The optional warning sanitizer was already proposed in central #2117; new commitfb4b3338narrows the PTY threshold notice as well. Replaying this run's report and console through the current proposed classifier changes the false console signal from 1 to 0; 49 adjacent Strix tests pass locally. Central #2117 remains Draft with current-head checks queued and independent review outstanding, so this parent PR's hosted Strix failure is not resolved yet.At 2026-09-28 05:47 UTC, the org API listed six self-hosted Linux/X64 runners online and busy. This PR's queued
scan-pr-queuejob requiresself-hosted,linux,x64, while queuedTests and package qualityrequiresubuntu-24.04; both still hadrunner_id=0. These observations show backlog and no assigned runner for those jobs, not a source failure or proof of the sole scheduling cause. No parent HEAD change or gate bypass follows.