Skip to content

🎨 Palette: [UX improvement] Add accessible context to edge edit buttons #666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
seonghobae wants to merge 1 commit into from
Closed

🎨 Palette: [UX improvement] Add accessible context to edge edit buttons #666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,3 +54,6 @@
## 2024-07-13 - [Table Node Accessibility]
**Learning:** Adding `aria-hidden="true"` inside `abbr` elements with `aria-label` prevents screen readers from redundantly announcing short abbreviations like "PK" or "NN" along with their full label.
**Action:** When creating short, domain-specific abbreviations with tooltips, use `aria-label` on the wrapper and hide the visual text from screen readers using `aria-hidden="true"` to create a cleaner auditory experience.
## 2024-07-28 - [Accessible Generic Dialog Action Buttons]
**Learning:** Generic action buttons (like "Save", "Cancel", or "Delete") in context-specific dialogs (such as the Edit Relation modal) can be ambiguous for screen reader users, who hear only the short, generic text without the visual context describing the entities involved (e.g. source and target tables).
**Action:** Always provide full context via `aria-label` for generic action buttons in dialogs to clarify what is being acted upon (e.g., `aria-label="\${source}μ—μ„œ \${target} 관계 μ €μž₯"`), creating a more transparent auditory experience.
4 changes: 3 additions & 1 deletion frontend/src/components/modals/EditEdgeModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,14 +83,16 @@ export function EditEdgeModal({
type="button"
onClick={onRelDelete}
style={{ color: "#b91c1c", borderColor: "#fca5a5" }}
aria-label={`${editingEdge.source}μ—μ„œ ${editingEdge.target} 관계 μ‚­μ œ`}
>
μ‚­μ œ
</button>
<div className="row">
<button type="button" onClick={onRelCancel}>μ·¨μ†Œ</button>
<button type="button" onClick={onRelCancel} aria-label={`${editingEdge.source}μ—μ„œ ${editingEdge.target} 관계 μ·¨μ†Œ`}>μ·¨μ†Œ</button>
<button
type="submit"
style={{ background: "#034ea2", color: "#fff" }}
aria-label={`${editingEdge.source}μ—μ„œ ${editingEdge.target} 관계 μ €μž₯`}
>
μ €μž₯
</button>
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/components/modals/ModalCoverage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,9 @@ describe('modal behavior coverage', () => {
fireEvent.change(screen.getByLabelText('μ œμ•½μ‘°κ±΄ 이름 (Label)'), {
target: { value: 'fk_changed' },
})
fireEvent.click(screen.getByRole('button', { name: 'μ‚­μ œ' }))
fireEvent.click(screen.getByRole('button', { name: 'μ·¨μ†Œ' }))
fireEvent.click(screen.getByRole('button', { name: 'μ €μž₯' }))
fireEvent.click(screen.getByRole('button', { name: 'aμ—μ„œ b 관계 μ‚­μ œ' }))
fireEvent.click(screen.getByRole('button', { name: 'aμ—μ„œ b 관계 μ·¨μ†Œ' }))
fireEvent.click(screen.getByRole('button', { name: 'aμ—μ„œ b 관계 μ €μž₯' }))
expect(setRelLabel).toHaveBeenCalledWith('fk_changed')
expect(onDelete).toHaveBeenCalledOnce()
expect(onCancel).toHaveBeenCalledOnce()
Expand Down
Loading