Skip to content

Stop scrollbars from flickering on/off when resizing windows #3887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shroffk merged 2 commits into from
Jul 16, 2026
+25 −49
Merged

Stop scrollbars from flickering on/off when resizing windows #3887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e960a31
Stop scrollbars from flickering on/off when resizing windows
rjwills28 Jul 13, 2026
9ff7086
Catch case when model is null and return
rjwills28 Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 20 additions & 46 deletions ...x/src/main/java/org/csstudio/display/builder/representation/javafx/JFXRepresentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,9 +225,12 @@ final public ScrollPane createModelRoot()
model_root = new ScrollPane(scroll_body);
model_root.setId(MODEL_ROOT_ID);

final InvalidationListener resized = prop -> handleViewportChanges();
model_root.widthProperty().addListener(resized);
model_root.heightProperty().addListener(resized);
// Update background of parent when it changes or, for example,
// becomes not null
final InvalidationListener background = prop -> {
updateBackground();
};
model_root.parentProperty().addListener(background);

// Middle Button (Wheel press) drag panning started
final EventHandler<MouseEvent> onMousePressedHandler = evt ->
Expand Down Expand Up @@ -647,48 +650,6 @@ public ToolkitRepresentation<Parent, Node> openNewWindow(final DisplayModel mode
throw new IllegalStateException("Not implemented");
}

/** Handle changes in on-screen size of this representation */
private void handleViewportChanges()
{
final int view_width = (int) model_root.getWidth();
final int view_height = (int) model_root.getHeight();

final int model_width, model_height;
final DisplayModel copy = model;
if (copy == null)
model_width = model_height = 0;
else
{
model_width = copy.propWidth().getValue();
model_height = copy.propHeight().getValue();
}

// If on-screen viewport is larger than model,
// grow the scroll_body so that the complete area is
// filled with the background color
// and - in edit mode - the grid.
// If the viewport is smaller, use the model's size
// to get appropriate scrollbars.
final int show_x = view_width >= model_width
? view_width-SCROLLBAR_ADJUST
: model_width;
final int show_y = view_height >= model_height
? view_height-SCROLLBAR_ADJUST
: model_height;

// Does not consider zooming.
// If the widget_pane is zoomed 'out', e.g. 50%,
// the widget_pane will only be half as large
// as we specify here in pixels
// -> Ignore. If user zooms out a lot, there'll be an
// area a gray area at the right and bottom of the display.
// But user tends to zoom out to see the complete set of widgets,
// so there is very little gray area.
// widget_parent.setMinWidth(show_x / zoom);
// widget_parent.setMinHeight(show_y / zoom);
widget_pane.setMinSize(show_x, show_y);
}

/** Update lines that indicate model's size in edit mode */
private void updateModelSizeIndicators()
{
Expand Down Expand Up @@ -934,6 +895,9 @@ public String showSaveAsDialog(final Widget widget, final String initial_value)
/** Update background, using background color and grid information from model */
private void updateBackground()
{
if (model == null)
return;

final WidgetColor background = model.propBackgroundColor().getValue();

// Setting the "-fx-background:" of the root node propagates
Expand Down Expand Up @@ -992,7 +956,17 @@ private void updateBackground()
final WritableImage wimage = new WritableImage(gridStepX, gridStepY);
SwingFXUtils.toFXImage(image, wimage);
final ImagePattern pattern = new ImagePattern(wimage, 0, 0, gridStepX, gridStepY, false);
widget_pane.setBackground(new Background(new BackgroundFill(pattern, CornerRadii.EMPTY, Insets.EMPTY)));
Background bg = new Background(new BackgroundFill(pattern, CornerRadii.EMPTY, Insets.EMPTY));

// Set the background of the parent BorderPane
if (model_root.getParent() instanceof Pane)
((Pane) model_root.getParent()).setBackground(bg);
// Now make the scroll pane transparent to see the parent background
model_root.setStyle("-fx-background: transparent; -fx-background-color: transparent; ");
// Also set background of content to workaround JFX bugs (https://bugs.openjdk.org/browse/JDK-8118303
// and https://bugs.openjdk.org/browse/JDK-8095008) where text is rendered badly inside a transparent
// ScrollPane.
widget_pane.setBackground(bg);
}

// Future for controlling the audio player
Expand Down
8 changes: 5 additions & 3 deletions ...n/java/org/csstudio/display/builder/representation/javafx/widgets/TabsRepresentation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
import java.util.concurrent.atomic.AtomicBoolean;
import java.util.logging.Level;

import javafx.scene.layout.*;
import javafx.scene.paint.Color;
import org.csstudio.display.builder.model.DirtyFlag;
import org.csstudio.display.builder.model.UntypedWidgetPropertyListener;
import org.csstudio.display.builder.model.Widget;
Expand All @@ -33,9 +35,6 @@
import javafx.scene.control.Tab;
import javafx.scene.control.TabPane;
import javafx.scene.input.MouseEvent;
import javafx.scene.layout.Background;
import javafx.scene.layout.BackgroundFill;
import javafx.scene.layout.Pane;
import javafx.scene.text.Font;

/** Creates JavaFX item for model widget
Expand Down Expand Up @@ -295,12 +294,15 @@ public void updateChanges()
{ // Set the font of the 'graphic' that's used to represent the tab
final Label label = (Label) tab.getGraphic();
label.setFont(tab_font);
label.setTextFill(Color.BLACK);

// Set colors
tab.setStyle(style);

final Pane content = (Pane) tab.getContent();
content.setBackground(background);
content.setBorder(new Border(new BorderStroke(Color.WHITE,
BorderStrokeStyle.SOLID, CornerRadii.EMPTY, BorderWidths.DEFAULT)));
}

final Integer width = model_widget.propWidth().getValue();
Expand Down
Loading