Skip to content

COR-1766: report dirty worktree state with corgea scan uploads - #150

Merged
leenk7991 merged 6 commits into
mainfrom
cor-1764-incremental-scans
Aug 12, 2026
Merged

COR-1766: report dirty worktree state with corgea scan uploads#150
leenk7991 merged 6 commits into
mainfrom
cor-1764-incremental-scans

Conversation

@leenk7991

Copy link
Copy Markdown
Member

Summary

  • Report worktree dirty state on BLAST uploads (dirty=true|false next to sha) so doghouse can skip commit-diff incremental scans.
  • Print a short notice when scanning uncommitted local files.
  • Status check failures fail safe to dirty; detect after packaging so the flag matches the archive.
  • pairs with https://github.com/Corgea/doghouse/pull/1838

Test plan

  • ./harness check
  • Clean tree: corgea scan — no dirty notice; multipart dirty=false
  • Edit tracked file, rescan same SHA — dirty notice + dirty=true; with COR-1765, full scan (not stale copy)
  • Gitignored-only file — no dirty notice
  • Confirm COR-1765 deployed before release

Comment thread src/scanners/blast.rs Outdated
Comment thread src/utils/api.rs
Comment thread src/utils/generic.rs Outdated
@corgea-security corgea-security added the dennis-reviewed Dennis completed an automated review label Aug 6, 2026

@corgea-security corgea-security left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review risk: 4/5.

The new dirty flag can incorrectly identify partial or inconsistent archives as clean HEAD snapshots, making incremental scan results unsound.

Critical or high-priority changes must be addressed.

Automatic approval was not submitted: automated review found critical or high-priority findings.

Comment thread src/utils/generic.rs
Comment thread src/utils/generic.rs Outdated
@leenk7991
leenk7991 requested a review from juangaitanv August 12, 2026 09:15
Comment thread src/utils/generic.rs Outdated

@juangaitanv juangaitanv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@leenk7991
leenk7991 merged commit df234a4 into main Aug 12, 2026
17 checks passed
cursor Bot pushed a commit that referenced this pull request Aug 13, 2026
Conflict in the blast staging block: main (#150) dropped the get_repo_info call
that sat after it, replacing it with the repo_before/repo_after pair that feeds
reconcile_repo_info_for_upload. Kept this branch's create_private_temp_dir and
main's new repo-state handling, and removed the now-stale repo_info binding.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dennis-reviewed Dennis completed an automated review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants