Repository navigation
fix(ptsChart): tolerate sets without points-to-set tuples (SCORING-102) - #183
Merged
Merged
Conversation
The factory's v2 kernel omits `needed` tuples for timed, aggregate and outs sets. update() read `pointsToSet[0]` unguarded, so SET1-S:T10 and SET3-S:TB7-F:T10 threw and the whole chart died. - points without a tuple stay undefined in place and draw as a line gap (line.defined), never a substituted [0,0]; their breakpoint circles are hidden; point order is kept - the y-domain and pre-match start come from the tuples that exist - ptsMatch hides a set's series entirely when none of its points carries a tuple Tests: complete (TB7), all-timed (T10), mixed (TB7-F:T10) and a mid-set gap, rendered from a real ScoringEngine through buildEpisodes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016hSeUnCAQmFm1Cf6UvzPo5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The factory's v2 kernel omits
neededtuples for timed, aggregate and outs sets.ptsChartupdate()readpointsToSet[0]unguarded, soSET1-S:T10(no tuples) andSET3-S:TB7-F:T10(3 of 17 absent) threwCannot read properties of undefined (reading '0')and the whole chart died.undefinedin place and draw as a line gap (line().defined). No[0,0]is substituted. Their breakpoint circles are hidden and point order is kept.ptsMatchhides a set's series entirely when none of its points carries a tuple.Tests
src/__tests__/ptsChartOptionalNeeded.test.ts(happy-dom, realScoringEngine→buildEpisodes→ptsMatch().update()):complete (TB7), all-timed (T10), mixed (TB7-F:T10) and a mid-set gap (vertex counts, monotonic x, gap width).
origin/dev3 of 4 fail with the reported TypeError (the complete case passes as a control).pnpm lint(0 warnings),pnpm check-types,pnpm test: 15 files, 199 tests pass.Companion: epixodic
fix/points-to-support-gate(realsupportsPointsToVisualization).🤖 Generated with Claude Code