Skip to content

Address Mypy Errors #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MattToast merged 3 commits into from
May 13, 2026
Merged

Address Mypy Errors #798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
626bccf
Remove implicit redefinition of variable
MattToast Apr 20, 2026
d36943c
Remove unused suppression
MattToast Apr 20, 2026
1a47a2b
Add changelog entry
MattToast Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions doc/changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,8 @@ Detailed Notes
([SmartSim-PR738](https://github.com/CrayLabs/SmartSim/pull/738))
- Removes an undocumented and unused dependency from the testing suite.
([SmartSim-PR792](https://github.com/CrayLabs/SmartSim/pull/792))
- Address potential type errors in SmartSim.
([SmartSim-PR798](https://github.com/CrayLabs/SmartSim/pull/798))


### 0.8.0
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,6 @@ module = [
"keras",
"torch",
"smartsim.ml.torch.*", # must solve/ignore inheritance issues
"watchdog",
"dragon.*",
]
ignore_missing_imports = true
Expand Down
4 changes: 2 additions & 2 deletions smartsim/entity/model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,8 @@ def _stringify_id(_id: int) -> str:
return ",".join(_stringify_id(i) for i in range(cpus))
if not pin_ids:
return None
pin_ids = ((x,) if isinstance(x, int) else x for x in pin_ids)
to_fmt = itertools.chain.from_iterable(pin_ids)
pin_ids_ = ((x,) if isinstance(x, int) else x for x in pin_ids)
to_fmt = itertools.chain.from_iterable(pin_ids_)
return ",".join(sorted({_stringify_id(x) for x in to_fmt}))

def params_to_args(self) -> None:
Expand Down
Loading