Skip to content

Ruined Portal Mirrored Incorrectly in getVariant #160

Description

@DuncanRuns

MC 1.16.1 decompiled & mapped with yarn:
BlockMirror blockMirror = this.random.nextFloat() < 0.5F ? BlockMirror.NONE : BlockMirror.FRONT_BACK;
MC 1.21.11 decompiled & mapped with yarn:
BlockMirror blockMirror = chunkRandom.nextFloat() < 0.5F ? BlockMirror.NONE : BlockMirror.FRONT_BACK;
So <0.5 means no mirroring

Cubiomes:
r->mirror = nextFloat(&rng) < 0.5f;
So <0.5 means mirror = 1

It can of course be defined that mirror = 1 means no mirroring and mirror = 0 means mirrored front to back, but that doesn't seem intuitive to me.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions