Update to Minecraft 26.3 - #75
Merged
Merged
Conversation
* Replace the removed org.lwjgl.glfw key constants with InputConstants * Block#codec and the block type codec registry are gone * Player#drop now takes a Prediction * FriendlyByteBuf#writeIntIdList/readIntIdList were removed, use var int arrays * Stop delegating the script text area to EditBox#charTyped, which swallowed typed characters into its own unused value * Replace the deprecated logoFile with iconFile Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
26.3 replaced the "functions"/"conditions" lists with a single "modifier"/"condition" holder, and the inline "function"/"condition" type keys with "type". The old format parses without errors but is ignored, so copy_name and survives_explosion had become no-ops. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
The mod jar is built for 26.3, but the step still spun up a 26.2 server, so the mod could not load and the job failed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf
Coverage Report for CI Build 35521599929Coverage increased (+0.2%) to 51.236%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions157 previously-covered lines in 3 files lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports IntegratedScripting to Minecraft 26.3 (NeoForge
26.3.0.7-beta), with CyclopsCore1.30.0-1159, IntegratedDynamics1.33.4-2157, IntegratedTerminals1.6.6-513and the moddev plugin at2.0.147.Changes
org.lwjgl.glfwis gone.InputConstantsreplaces it, but not one for one: input moved to SDL scancodes, soGLFW_KEY_ESCAPEmaps toKEY_ESCAPE(41) rather than to a same-named constant.The script text area swallowed every typed character.
WidgetTextArea#charTypeddelegated toEditBox#charTyped, which inserts into theEditBox's own value, not the text area's. In 26.3 that path also stopped returningtrue, so nothing typed into the script editor ever appeared. It now inserts through its owntextFieldHelperdirectly. This is pre-existing rather than a 26.3 regression: it dates from the June 2025 switch toEditBox, andEditBox#charTyped/canConsumeInput()are unchanged across 26.0 through 26.3.Smaller API moves.
Block#codec()and the block type codec registry were removed;Player#droptakes aPrediction;FriendlyByteBuf#writeIntIdList/readIntIdListare gone, replaced by var int arrays;logoFileis deprecated in favour oficonFile.Loot table format. 26.3 replaced the
"functions"/"conditions"lists with a single"modifier"/"condition"holder, and the inline"function"/"condition"type keys with"type". The old format parses without any error and is then ignored, so the scripting drive'scopy_nameandsurvives_explosionhad silently become no-ops. Same problem as CyclopsMC/IntegratedDynamics#1743.CI. The
Test in production serverstep pinnedmc: 26.2, so it spun up a 26.2 server against a 26.3 jar and every matrix job failed at that step with the build and unit tests passing. Bumped to26.3. This repo is the only one in the family that hardcodes an MC version in its workflow.Validation
./gradlew buildpasses../gradlew runGameTestServer: all required tests pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01V35MFZ7JSgoLe79J4d1uxf