Repository navigation
Conversation
The rebuild job checks out the PR head SHA, which leaves a detached HEAD, so the bare `git push` in the auto-commit step exited with "You are not currently on a branch". Push HEAD to the PR branch explicitly. A branch that moved since the run started is rejected as non-fast-forward instead of being overwritten. Also run the workflow when the workflow file itself changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c93dfcde49
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Lease the push on the PR head SHA the run built from. A plain push still landed when the branch was reset to an ancestor or deleted during the run; with the lease, any change to the branch rejects the push. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
rebuild-distjob checks out the PR head SHA, so the working copy is a detached HEAD. Whenattest/dist/index.jswas out of date, the auto-commit step then ran a baregit push, which exits withfatal: You are not currently on a branch(seen on #135). Authors had to rebuild and commit the bundle by hand.Changes
git push --force-with-lease="refs/heads/$PR_HEAD_REF:$PR_HEAD_SHA" origin "HEAD:refs/heads/$PR_HEAD_REF". Both values come fromgithub.event.pull_request.headthroughenv:. The push lands only while the branch still points at that SHA; if it moved forward, was reset to an earlier commit, or was deleted during the run, the push is rejected..github/workflows/build-attest-dist.yamlchanges, so edits to it are exercised on their own PR.Validation
The step script was extracted from the workflow and run against a local repository, checked out at a detached PR head with the bundle rebuilt:
You are not currently on a branchdist already up to dateOn this PR the workflow runs because the workflow file changed, and the bundle is already in sync, so it exits early. The push path runs on the next PR that changes
attest/index.jswithout committing the bundle.Note: a push made with
GITHUB_TOKENdoes not start new workflow runs, so the bot commit carries no checks of its own. Push another commit, or re-run the workflows, if checks are needed on it.🤖 Generated with Claude Code