馃Ч fix(core): integrate validate_safe_path in core path operations - #408
馃Ч fix(core): integrate validate_safe_path in core path operations#408Cylae wants to merge 1 commit into
Conversation
Integrate validate_safe_path into core filesystem and locking operations (atomic_write, ProcessLock::acquire, Journal::open_or_create) to prevent path traversal attacks.
|
馃憢 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 馃憖 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Rationale
The public function
validate_safe_pathinserver_manager/src/core/validate.rsprovides path traversal protection (..rejection). By integratingvalidate_safe_pathdirectly into core filesystem and locking functions (atomic_write,ProcessLock::acquire, andJournal::open_or_create), system-wide path safety is enforced while resolving unused code concerns.Changes
server_manager/src/core/atomic_io.rs: Validates destination paths viavalidate_safe_pathinatomic_write.server_manager/src/core/lock.rs: Validates lockfile paths viavalidate_safe_pathinProcessLock::acquire.server_manager/src/core/journal.rs: Validates journal file paths viavalidate_safe_pathinJournal::open_or_create.Verification
./verify.shcoveringcargo fmt,cargo clippy,cargo test,cargo deny, andcargo audit. All checks passed cleanly.PR created automatically by Jules for task 10011583263562090100 started by @Cylae