Skip to content

security: enforce safe path validation in atomic I/O, lock, and journal - #415

Open
Cylae wants to merge 1 commit into
mainfrom
jules-12468028964604981280-c35a1273
Open

security: enforce safe path validation in atomic I/O, lock, and journal#415
Cylae wants to merge 1 commit into
mainfrom
jules-12468028964604981280-c35a1273

Conversation

@Cylae

@Cylae Cylae commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Enhances path safety validation across core file operations (atomic_write), process locking (ProcessLock::acquire), and transactional journaling (Journal::open_or_create). Rejects NUL bytes (\0) and ASCII control characters in validate_safe_path alongside directory traversal prevention. Adds unit and contract tests for all modified components. All ./verify.sh checks (formatting, clippy, unit/integration/contract tests, cargo deny, cargo audit) pass cleanly.


PR created automatically by Jules for task 12468028964604981280 started by @Cylae

Enhance `validate_safe_path` to reject NUL bytes and control characters in addition to path traversal sequences (`..`). Apply `validate_safe_path` to `atomic_write`, `ProcessLock::acquire`, and `Journal::open_or_create`. Include comprehensive unit and contract tests verifying safe path enforcement.
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant