Repository navigation
feat(slideshow): per-service "Slideshow: Disabled (DLS only)" - #56
Merged
Merged
Conversation
A new "Slideshow" setting beside the PAD size (Enabled by default). Disabled: - no image goes on air: _syncAirSlides() leaves mot/<PI>/air empty, so odr-padenc sends DLS / DL+ only; slide/ (logos, covers) is untouched; - receivers are not told to expect a slideshow: muxBuilder leaves out `figtype 0x2` for that component. figtype 0x2 alone makes odr-dabmux 5.1 announce a slideshow (FIG 0/13), even with no user-applications block (checked with dablin on a test mux); - unused PAD bytes go back to the audio (an AU carries a PAD only when odr-padenc has data: ~0.3 B/AU with DLS only, PAD 16). Stored in the existing pad.sls.enabled field (already in every preset, true), so the preset format is unchanged. The field is missing or true -> previous behaviour: the .mux generated for the production preset (12 services) is byte-identical before / after. It is mux-stopped-only like the PAD size (the .mux changes); ON AIR the form does Stop -> save -> Start. Tests: slideshow.test.js (air dir, setService stopped / ON AIR, addService, .mux) and muxBuilder signalling cases. 314/314 pass. Checked end to end on an isolated test mux (EDI to an unused port): toggled both ways, dablin sees the slideshow only on the enabled service. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Some services do not need slides, but today every service sends logos and covers, and every service is announced to receivers as having a slideshow. A PAD carrying images takes 6–23 kbps from the audio (see #55). With DLS only, an AU carries almost no PAD: about 0.3 bytes per AU were measured with PAD 16, because an AU carries a PAD only when odr-padenc has data. The rest goes back to the audio.
What changes
A Slideshow setting beside the PAD size, with the values
Enabled(default) andDisabled (DLS only). When it is disabled:_syncAirSlides()leavesmot/<PI>/airempty, so odr-padenc sends DLS / DL+ only.slide/(logos, covers) stays untouched and remains the source of truth.muxBuilderleaves outfigtype 0x2for that component. On its own, this deprecated setting makes odr-dabmux 5.1 announce a slideshow (FIG 0/13), even with nouser-applicationsblock. This was checked with dablin on a test mux: without the line, the service is a normal DAB+ service (label, PTY, audio) with no slideshow announced.Compatibility (preset / .mux / ON AIR)
pad.sls.enabled, already present (true) in every preset. A missing field ortruegives the previous behaviour..muxunchanged for existing services: the.muxgenerated from the production preset (12 services) is byte-identical before and after this change..muxchanges.setServiceignores it ON AIR, and the form adds it toMUX_RESTART_FIELDS, so ON AIR it does Stop → save → Start after confirmation.addServicehonours it for a new service. The import path already keepspad.sls.Critical files:
appState.js(3 small hunks:setService,addService,_syncAirSlides) andmuxBuilder.js(1 line). Both were changed together on purpose, with the maintainer's explicit approval (CLAUDE.md §3.5), because the setting is only half-done without the signalling.Tests
server/tests/slideshow.test.js(new): old presets stay on; disabled empties the air dir and leavesslide/untouched; re-enabled brings the slides back;setServicewhile stopped vs ON AIR;addService; the.muxcontains neitheruserappnorfigtypewhen disabled.muxBuilder.test.js: slideshow on (unchanged output), nopadfield (old preset:figtypekept), slideshow disabled.🤖 Generated with Claude Code