Skip to content

feat(slideshow): per-service "Slideshow: Disabled (DLS only)" - #56

Merged
DABodr merged 1 commit into
mainfrom
feat/disable-slideshow
Nov 16, 2026
Merged

DABodr merged 1 commit into
mainfrom
feat/disable-slideshow

Conversation

@DABodr

@DABodr DABodr commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Stacked on #55: it extends the PAD hint added there. Merge #55 first; GitHub then retargets this PR to main.

Why

Some services do not need slides, but today every service sends logos and covers, and every service is announced to receivers as having a slideshow. A PAD carrying images takes 6–23 kbps from the audio (see #55). With DLS only, an AU carries almost no PAD: about 0.3 bytes per AU were measured with PAD 16, because an AU carries a PAD only when odr-padenc has data. The rest goes back to the audio.

What changes

A Slideshow setting beside the PAD size, with the values Enabled (default) and Disabled (DLS only). When it is disabled:

  • No image goes on air. _syncAirSlides() leaves mot/<PI>/air empty, so odr-padenc sends DLS / DL+ only. slide/ (logos, covers) stays untouched and remains the source of truth.
  • Receivers are not told to expect a slideshow. muxBuilder leaves out figtype 0x2 for that component. On its own, this deprecated setting makes odr-dabmux 5.1 announce a slideshow (FIG 0/13), even with no user-applications block. This was checked with dablin on a test mux: without the line, the service is a normal DAB+ service (label, PTY, audio) with no slideshow announced.
  • The PAD hint says "Slideshow off", and the services table greys the thumbnail.

Compatibility (preset / .mux / ON AIR)

  • No new preset field: the setting is stored in the existing pad.sls.enabled, already present (true) in every preset. A missing field or true gives the previous behaviour.
  • .mux unchanged for existing services: the .mux generated from the production preset (12 services) is byte-identical before and after this change.
  • The setting can only change while the mux is stopped, like the PAD size, because the .mux changes. setService ignores it ON AIR, and the form adds it to MUX_RESTART_FIELDS, so ON AIR it does Stop → save → Start after confirmation.
  • addService honours it for a new service. The import path already keeps pad.sls.

Critical files: appState.js (3 small hunks: setService, addService, _syncAirSlides) and muxBuilder.js (1 line). Both were changed together on purpose, with the maintainer's explicit approval (CLAUDE.md §3.5), because the setting is only half-done without the signalling.

Tests

  • server/tests/slideshow.test.js (new): old presets stay on; disabled empties the air dir and leaves slide/ untouched; re-enabled brings the slides back; setService while stopped vs ON AIR; addService; the .mux contains neither userapp nor figtype when disabled.
  • muxBuilder.test.js: slideshow on (unchanged output), no pad field (old preset: figtype kept), slideshow disabled.
  • 314/314 pass.
  • End to end on an isolated test instance (EDI to an unused port, PIs and PAD sockets distinct from production): two services, slideshow toggled both ways through Stop → PATCH → Start, the preset saved on disk, and dablin seeing the slideshow only on the enabled service.

🤖 Generated with Claude Code

A new "Slideshow" setting beside the PAD size (Enabled by default). Disabled:
- no image goes on air: _syncAirSlides() leaves mot/<PI>/air empty, so
  odr-padenc sends DLS / DL+ only; slide/ (logos, covers) is untouched;
- receivers are not told to expect a slideshow: muxBuilder leaves out
  `figtype 0x2` for that component. figtype 0x2 alone makes odr-dabmux 5.1
  announce a slideshow (FIG 0/13), even with no user-applications block
  (checked with dablin on a test mux);
- unused PAD bytes go back to the audio (an AU carries a PAD only when
  odr-padenc has data: ~0.3 B/AU with DLS only, PAD 16).

Stored in the existing pad.sls.enabled field (already in every preset,
true), so the preset format is unchanged. The field is missing or true ->
previous behaviour: the .mux generated for the production preset (12
services) is byte-identical before / after. It is mux-stopped-only like
the PAD size (the .mux changes); ON AIR the form does Stop -> save -> Start.

Tests: slideshow.test.js (air dir, setService stopped / ON AIR, addService,
.mux) and muxBuilder signalling cases. 314/314 pass. Checked end to end on
an isolated test mux (EDI to an unused port): toggled both ways, dablin
sees the slideshow only on the enabled service.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T23:06:30.734055Z 445c72c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@DABodr
DABodr deleted the branch feat/pad-bitrate-hint November 16, 2026 23:08
@DABodr DABodr closed this Nov 16, 2026
@DABodr DABodr reopened this Nov 16, 2026
@DABodr
DABodr changed the base branch from feat/pad-bitrate-hint to main November 16, 2026 23:09
@DABodr
DABodr merged commit 8ed4035 into main Nov 16, 2026
2 checks passed
@DABodr
DABodr deleted the feat/disable-slideshow branch November 16, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant