Repository navigation
release-age: document uv lock interaction with exclude-newer - #186
Merged
Merged
Conversation
Owner
Author
Review SummaryNo findings. Both changes do what the description says.
Verified: Verdict: approve |
uv records the user-level exclude-newer in uv.lock ([options] exclude-newer-span), so the gate invalidates locks made without it (`--locked` fails, `uv run` re-resolves) and locks re-made under it fail `--locked` elsewhere. The README's "Lockfiles win" and uv.toml's "versions already in uv.lock are kept" said otherwise. The test-isolation fix originally in this change (PATH without the system npm, sandboxed HOME) landed independently in #187; main's version of tests/release-age.test.sh is kept.
DJRHails
force-pushed
the
release-age-review-fixes
branch
from
October 9, 2026 17:53
49e496b to
6a30dc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #185, which was already merged when the review ran. See the inline review.
exclude-newerintouv.lock([options] exclude-newer-span = "P7D"). A lock made without the gate failsuv sync --locked/uv lock --checkon a gated host, anduv runre-resolves it. A lock re-made on a gated host fails--lockedeverywhere else. Reproduced on uv 0.12.23. The README's "Lockfiles win" and the uv.toml comment now say so. Whether to keep uv gated at user level, or move to a per-repo[tool.uv]setting, is a separate decision this PR does not make.tests/release-age.test.sh(filtered system bin dir, sandbox HOME) independently. I resolved the conflict by keeping main's test, so this PR now changes only docs.Verified after rebase:
bash tests/release-age.test.shunder a throwaway HOME prints "all passed" (1 skip: no cargo here).via gantry