Skip to content

Close CRM gaps + harden credit-note logging - #878

Merged
evilguy4000 merged 6 commits into
developfrom
feat/close-invoicing-gaps
Nov 15, 2026
Merged

evilguy4000 merged 6 commits into
developfrom
feat/close-invoicing-gaps

Conversation

@evilguy4000

Copy link
Copy Markdown
Collaborator

Summary

  • Close remaining CRM gaps: API activities/conversion/pipeline stage moves/forecast/source analytics; web pipeline drag-and-drop, communication templates, and calendar reminders; desktop/mobile field mapping and email-to-deal matching fixes; timezone Settings lookups no longer roll back in-flight CRM mutations.
  • Harden credit-note handlers against CodeQL log-injection and stack-trace exposure by sanitizing logged route IDs and stopping exception text from being echoed to clients.

Migrations

  • 213_crm_communication_templates

Test plan

  • API: lead activities, convert lead, deal stage move, forecast, and source analytics endpoints return expected payloads with CRM scopes
  • Web: drag a deal between pipeline stages; create/use a communication template; verify calendar reminder links
  • Desktop CRM view and mobile client detail / CRM hub show mapped fields without errors
  • Create credit note / download PDF or XML — errors do not leak stack traces; logs stay free of raw unsanitized IDs
  • pytest tests/test_api_crm_v1.py tests/test_credit_notes.py -q

Sanitize logged route IDs and stop echoing exception text to clients so credit-note create/PDF/XML handlers no longer trip log-injection or stack-trace exposure findings.
Add activities, conversion, pipeline stage moves, forecast, and source analytics to the API; ship pipeline drag-and-drop, communication templates, and calendar reminders on web; fix desktop/mobile field mapping and email-to-deal matching; and prevent Settings timezone lookups from rolling back in-flight CRM mutations.
Unblock Lint and Frontend assets checks for the CRM follow-up PR.
Comment thread tests/test_api_crm_v1.py Fixed
Attach the webhook relationship and default retry_count on create so
mark_failed/mark_success still update counters when timezone lookup
skips Settings while the session has pending CRM work.
base.html defines scripts_extra, not scripts, so the pipeline page script
was never rendered and failed template block coverage.
@evilguy4000
evilguy4000 merged commit d465870 into develop Nov 15, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant