Fix e2e workflow so validation mode actually runs#8
Merged
Conversation
sachin-panayil
approved these changes
Jul 21, 2026
sachin-panayil
left a comment
sachin-panayil
left a comment
Contributor
There was a problem hiding this comment.
lgtm. curious as to how you manually fed in a commit?
Collaborator
Author
Using the Github CLI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes found by actually running the e2e. The local action ref couldn't find the Dockerfile, and validation mode never ran because GITHUB_EVENT_NAME can't be set through
uses:, so the "validate" steps were quietly generating PRs instead.Changes
./.e2e-actionref builds (the repo ships it lowercase)docker runwith-e GITHUB_EVENT_NAME=pull_request, the only way to put the action in validation mode from hereTesting
Verified with a live run: all three modes pass, the broken fixture is correctly rejected, exactly one PR is opened, and cleanup leaves the repo clean.