fix(evm): fix real block sync issue for multipass#573
Open
starwarfan wants to merge 5 commits into
Open
Conversation
Ensure cached interpreter instances are initialized with the call revision and correct CALL stipend accounting so Silkworm replay matches per-tx gas expectations. This removes WrongBlockGas mismatches observed on blocks 4318818 and 4318819 while keeping debug instrumentation for targeted gas tracing. Made-with: Cursor # Conflicts: # src/evm/opcode_handlers.cpp # src/runtime/evm_module.h # src/vm/dt_evmc_vm.cpp
Use full-byte code comparison when validating address-keyed module cache hits so re-created contracts cannot incorrectly reuse a prior compiled module. Made-with: Cursor # Conflicts: # src/vm/dt_evmc_vm.cpp
Silkworm runs initcode as EVMC_CALL with code_address zeroed. Persistent L1 cache keyed on 0x0 aliased unrelated initcodes and caused kWrongBlockGas on block 433153 during long multipass forward runs. Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # src/vm/dt_evmc_vm.cpp
# Conflicts: # src/compiler/evm_compiler.cpp # src/compiler/evm_frontend/evm_mir_compiler.cpp # src/compiler/evm_frontend/evm_mir_compiler.h # src/evm/evm_cache.cpp # src/evm/evm_cache.h # src/runtime/evm_module.cpp # src/runtime/evm_module.h # src/runtime/runtime.cpp # src/vm/dt_evmc_vm.cpp
⚡ Performance Regression Check Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note