Fail installation when downloading APT GPG keys returns an HTTP error - #460
Merged
robertomonteromiguel merged 1 commit intoSep 28, 2026
Conversation
Stanislas167
approved these changes
Sep 28, 2026
robertomonteromiguel
deleted the
robertomonteromiguel/fail-on-apt-gpg-key-http-errors
branch
September 28, 2026 12:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds
curl -fwhen downloading APT GPG keys.This makes
curlreturn a non-zero exit code for HTTP errors such as 403 or 404. The existing background-process handling will then detect the failure and stop the installation.Why?
If a GPG key download returns an HTTP error, the installation may continue without installing the Agent successfully. Downstream tests can then run against an invalid environment instead of stopping after the installation failure.